Fix exception when the list only contains a suggestion mode item #67132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
added
Area-IDE
LSP
dibarbet
force-pushed
the
lsp_only_suggestion_mode_item
branch
from
1e2ab52
to
48764ee
Compare
dibarbet
force-pushed
the
lsp_only_suggestion_mode_item
branch
from
48764ee
to
51469c4
Compare
sharwell
approved these changes
Mar 1, 2023
| SuggestionMode = list.SuggestionModeItem != null, | ||
| // If we have a suggestion mode item, we just need to keep the list in suggestion mode. | ||
| // We don't need to return the fake suggestion mode item. | ||
| SuggestionMode = list.SuggestionModeItem is not null, | ||
| IsIncomplete = isIncomplete, | ||
| }; |
There was a problem hiding this comment.
so it's ok if there are no items in teh list and no suggestion item for us to return this guy?
CyrusNajmabadi
approved these changes
Mar 1, 2023
genlu
approved these changes
Mar 1, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1755138