Revert "Merge pull request #62854 from CyrusNajmabadi/renameOOP5"

[dibarbet]

This reverts commit 28a9bc8, reversing
changes made to 8909116.

I believe this to be the cause of the failing rename integration tests, currently seeing (though not limited to)

Roslyn.VisualStudio.IntegrationTests.VisualBasic.BasicRename.VerifyAttributeCapitalizedRename
Roslyn.VisualStudio.IntegrationTests.VisualBasic.BasicRename.VerifyAttributeNotCapitalizedRename
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpRename.VerifyAttributeRename
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpRename.VerifyAttributeRenameWhileRenameClasss
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpRename.VerifyRenameCancellation

all start failing occasionally beginning with the build from #62854. The symptom is a timeout in waiting for the rename async operation to complete. These failures appear to occur only in builds with this change and errors in these tests before that are entirely different and less frequent, so I'm quite confident this is the cause.

https://dev.azure.com/dnceng/public/_build/results?buildId=1918864&view=ms.vss-test-web.build-test-results-tab&runId=49719056&resultId=100362

Server stack trace: 
   at System.Threading.CancellationToken.ThrowOperationCanceledException()
   at System.Threading.ManualResetEventSlim.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.SpinThenBlockingWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.InternalWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Roslyn.Hosting.Diagnostics.Waiters.TestWaitingService.WaitForTask(Task task, CancellationToken cancellationToken) in /_/src/VisualStudio/IntegrationTest/TestUtilities/InProcess/TestWaitingService.cs:line 84
   at Roslyn.Hosting.Diagnostics.Waiters.TestWaitingService.WaitForAsyncOperations(TimeSpan timeout, String featureName, Boolean waitForWorkspaceFirst) in /_/src/VisualStudio/IntegrationTest/TestUtilities/InProcess/TestWaitingService.cs:line 46
   at Microsoft.VisualStudio.IntegrationTest.Utilities.InProcess.VisualStudioWorkspace_InProc.WaitForAsyncOperations(TimeSpan timeout, String featuresToWaitFor, Boolean waitForWorkspaceFirst) in /_/src/VisualStudio/IntegrationTest/TestUtilities/InProcess/VisualStudioWorkspace_InProc.cs:line 79
   at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]& outArgs)
   at System.Runtime.Remoting.Messaging.StackBuilderSink.SyncProcessMessage(IMessage msg)

Exception rethrown at [0]: 
   at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
   at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
   at Microsoft.VisualStudio.IntegrationTest.Utilities.InProcess.VisualStudioWorkspace_InProc.WaitForAsyncOperations(TimeSpan timeout, String featuresToWaitFor, Boolean waitForWorkspaceFirst)
   at Microsoft.VisualStudio.IntegrationTest.Utilities.OutOfProcess.VisualStudioWorkspace_OutOfProc.WaitForAsyncOperations(TimeSpan timeout, String featuresToWaitFor, Boolean waitForWorkspaceFirst) in /_/src/VisualStudio/IntegrationTest/TestUtilities/OutOfProcess/VisualStudioWorkspace_OutOfProc.cs:line 35
   at Microsoft.VisualStudio.IntegrationTest.Utilities.OutOfProcess.InlineRenameDialog_OutOfProc.Invoke() in /_/src/VisualStudio/IntegrationTest/TestUtilities/OutOfProcess/InlineRenameDialog_OutOfProc.cs:line 23
   at Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpRename.VerifyRenameCancellation() in /_/src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpRename.cs:line 466

[dibarbet]

already mentioned to @CyrusNajmabadi offline

[dibarbet]

One failure that looks entirely unrelated (for investigation another day). Going to re-run, but otherwise this looks like it resolves the rename hang

[CyrusNajmabadi]

Sorry!!