Merge pull request #46393 from ryzngard/issue/46192_nre_save_rename #48253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name Check `Saved` on ProjectItem before calling Save
|
THIS SHOULD NOT BE MERGED UNTIL SERVICING DECISION IS MADE |
JoeRobich
approved these changes
Oct 2, 2020
This was referenced Oct 2, 2020
jasonmalinowski
approved these changes
Oct 8, 2020
Cosifne
reviewed
Oct 12, 2020
| @@ -18,7 +18,7 @@ jobs: | |||
| - job: VS_Integration | |||
| pool: | |||
| name: NetCorePublic-Pool | |||
| queue: buildpool.windows.10.amd64.vs2019.pre.open | |||
| queue: buildpool.windows.10.amd64.vs2019.open | |||
There was a problem hiding this comment.
So the reason for changing this is because when the branch is created vs2019.pre is 16.7 and now vs2019 is 16.7?
There was a problem hiding this comment.
Correct. We do not want to merge any of this change back into master. 16.8 already has the right things for this. We do want to test this on 16.7, which is now the released version, and integration tests won't pass on 16.8
Cosifne
approved these changes
Oct 12, 2020
|
Passing Validation Build: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/278954 (internal users only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fix for NRE on rename for servicing
Original PR #46393