Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic handling of function pointer types in the IDE #44564

Merged
merged 17 commits into from
May 29, 2020
Merged

Basic handling of function pointer types in the IDE #44564

merged 17 commits into from
May 29, 2020

Commits on May 26, 2020

  1. Basic handling of function pointer types in the IDE: 

    * Offer `delegate` keyword when function pointer types are permissible.
* Completion inside function pointer type argument lists (including valid ref modifiers)
* SymbolKey support.
* Basic formatting support.
* Support in add/remove parameter.
    @333fred
    333fred committed May 26, 2020
    Configuration menu
    Copy the full SHA
    d1971b8 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. PR Feedback and Tests 

    * Added tests for all the new code paths.
* Fixed up the formatter.
* Fixed up extract method's understanding of rvalues for function pointers.
    @333fred
    333fred committed May 28, 2020
    Configuration menu
    Copy the full SHA
    c703569 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'dotnet/features/function-pointers' into… 

    … ide

* dotnet/features/function-pointers:
  Revert implicit change.
  Rename test
  Other typo.
  Minor PR feedback.
  Add additional conversion verification.
  PR Feedback:
    @333fred
    333fred committed May 28, 2020
    Configuration menu
    Copy the full SHA
    3d643fa View commit details
    Browse the repository at this point in the history

  3. PR Feedback: 

    * Add additional testing.
* Implement symbol equivalence for function pointer types.
* Simplify the change signature dialog type resolution.
    @333fred
    333fred committed May 28, 2020
    Configuration menu
    Copy the full SHA
    4d82657 View commit details
    Browse the repository at this point in the history

  4. Remove redundant formatting rules. 

    Apply PR feedback.
    @333fred
    333fred committed May 28, 2020
    Configuration menu
    Copy the full SHA
    9052e85 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'dotnet/features/function-pointers' into… 

    … ide

* dotnet/features/function-pointers:
  Correct condition.
  Adjust reported conversion for explicit conversions to match method groups.
  PR Feedback: * Add additional tests. * Handle new GetTypeInfo case revealed by tests. * Rename variables for clarity.
  Fix up existing messaging.
  Clean up error messages for address of to non-function-pointer types.
    @333fred
    333fred committed May 28, 2020
    Configuration menu
    Copy the full SHA
    cba43db View commit details
    Browse the repository at this point in the history

  6. Address naming feedback from other PR.

    @333fred
    333fred committed May 28, 2020
    Configuration menu
    Copy the full SHA
    3ca29da View commit details
    Browse the repository at this point in the history

  7. PR feedback: 

    * More tests.
* Make the delegate keyword recommender a bit stricter.
    @333fred
    333fred committed May 28, 2020
    Configuration menu
    Copy the full SHA
    deeb912 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Readd spacing rule for delegate*, reorder for clarity.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    0150ae2 View commit details
    Browse the repository at this point in the history

  2. Remove unusued using.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    ee20709 View commit details
    Browse the repository at this point in the history

  3. Remove other unused using.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    d6b45ee View commit details
    Browse the repository at this point in the history

  4. Conditionally add using for non-codestyle.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    d57ff24 View commit details
    Browse the repository at this point in the history

  5. Update error messages for clarity and rename test.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    ed7c4ae View commit details
    Browse the repository at this point in the history

  6. Narrow factory types, add tests.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    dd47d72 View commit details
    Browse the repository at this point in the history

  7. Correct public API files, fix build script.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    6f706da View commit details
    Browse the repository at this point in the history

  8. Add missing diagnostics.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    5d4b41b View commit details
    Browse the repository at this point in the history

  9. Added parsing test.

    @333fred
    333fred committed May 29, 2020
    Configuration menu
    Copy the full SHA
    e8194c5 View commit details
    Browse the repository at this point in the history