Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Public API support for function pointer types #44436

Merged
merged 13 commits into from
May 28, 2020
Merged

Add Public API support for function pointer types #44436

merged 13 commits into from
May 28, 2020

Commits on May 20, 2020

  1. Add public API for creating function pointers.

    @333fred
    333fred committed May 20, 2020
    Configuration menu
    Copy the full SHA
    643db79 View commit details
    Browse the repository at this point in the history

  2. Support function pointers in IOperation and CFG.

    @333fred
    333fred committed May 20, 2020
    Configuration menu
    Copy the full SHA
    a3f19cc View commit details
    Browse the repository at this point in the history

  3. Add GetTypeInfo tests.

    @333fred
    333fred committed May 20, 2020
    Configuration menu
    Copy the full SHA
    9ce8ac6 View commit details
    Browse the repository at this point in the history

  4. Support GetSymbolInfo for function pointers.

    @333fred
    333fred committed May 20, 2020
    Configuration menu
    Copy the full SHA
    7814edd View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. Changes from feedback: 

    * Significantly expanded testing.
* Reworded exception messages.
* Simplified handling of getting semantic information in the CSharpSemanticModel.
* Added comments as appropriate.
* Added linux support for running the IOperation test hook from cli.
    @333fred
    333fred committed May 23, 2020
    Configuration menu
    Copy the full SHA
    09b6462 View commit details
    Browse the repository at this point in the history

  2. Use BoundNode's WasCompilerGenerated.

    @333fred
    333fred committed May 23, 2020
    Configuration menu
    Copy the full SHA
    1caf24a View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @333fred
    333fred committed May 23, 2020
    Configuration menu
    Copy the full SHA
    464cbb0 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. PR Feedback: 

    * Don't special case BoundConversions with a method group in GetSymbolInfo.
* Use a better error wording.
* Add some additional asserts.
* Pass type for all NoneOperations.
    @333fred
    333fred committed May 27, 2020
    Configuration menu
    Copy the full SHA
    4a58034 View commit details
    Browse the repository at this point in the history

  2. Add additional conversion verification.

    @333fred
    333fred committed May 27, 2020
    Configuration menu
    Copy the full SHA
    1edbf72 View commit details
    Browse the repository at this point in the history

  3. Minor PR feedback.

    @333fred
    333fred committed May 27, 2020
    Configuration menu
    Copy the full SHA
    b8d3d2c View commit details
    Browse the repository at this point in the history

  4. Other typo.

    @333fred
    333fred committed May 27, 2020
    Configuration menu
    Copy the full SHA
    2969eb9 View commit details
    Browse the repository at this point in the history

  5. Rename test

    @333fred
    333fred committed May 27, 2020
    Configuration menu
    Copy the full SHA
    e6e7a58 View commit details
    Browse the repository at this point in the history

  6. Revert implicit change.

    @333fred
    333fred committed May 27, 2020
    Configuration menu
    Copy the full SHA
    c4ba743 View commit details
    Browse the repository at this point in the history