Partial method tests from test plan review #44303
Conversation
|
@dotnet/roslyn-compiler Please review |
| } | ||
| "; | ||
|
|
||
| var comp = CompileAndVerify(source, options: TestOptions.UnsafeReleaseDll, parseOptions: TestOptions.RegularWithExtendedPartialMethods, verify: Verification.Fails); |
There was a problem hiding this comment.
verify: Verification.Fails [](start = 148, length = 26)
Why does verification fail?
There was a problem hiding this comment.
I believe the verifier is unhappy that locals are not initialized. This is similar to other SkipLocalsInit tests.
There was a problem hiding this comment.
Are we skipping init? If so, why is HasLocalsInit("C.M") returning false?
In reply to: 426860257 [](ancestors = 426860257)
There was a problem hiding this comment.
Yes. HasLocalsInit is returning false because we are skipping locals init. Normally it returns true in most cases, except when the method has no locals or when the SkipLocalsInitAttribute has been applied.
| } | ||
| "; | ||
|
|
||
| var comp = CompileAndVerify(source, options: TestOptions.UnsafeReleaseDll, parseOptions: TestOptions.RegularWithExtendedPartialMethods, verify: Verification.Fails); |
There was a problem hiding this comment.
TestOptions.UnsafeReleaseDll [](start = 57, length = 28)
Minor point: Is this needed?
There was a problem hiding this comment.
Unsafe is required to use SkipLocalsInit
Related to #43795
Includes tests suggested in test plan review.