Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 15.8 editor nuget to fix MEF issue in unit test #25975

Merged

Conversation

JieCarolHu
Copy link
Contributor

Ask Mode template not completed

Customer scenario

What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)

Bugs this fixes

#25608

Workarounds, if any

Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW

Risk

This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code

Performance impact

(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")

Is this a regression from a previous update?

Root cause analysis

How did we miss it? What tests are we adding to guard against it in the future?

How was the bug found?

(E.g. customer reported it vs. ad hoc testing)

Test documentation updated?

If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.

@JieCarolHu JieCarolHu requested review from a team as code owners April 6, 2018 00:33
@JieCarolHu
Copy link
Contributor Author

retest windows_debug_unit32_prtest please

@JieCarolHu
Copy link
Contributor Author

retest windows_debug_unit64_prtest please

@JieCarolHu
Copy link
Contributor Author

retest windows_release_unit32_prtest please

@JieCarolHu
Copy link
Contributor Author

retest windows_debug_unit32_prtest

@JieCarolHu JieCarolHu merged commit d5a933f into dotnet:features/quick-info-party Apr 6, 2018
@JieCarolHu JieCarolHu deleted the fixMefIssue branch April 6, 2018 20:34
@JieCarolHu JieCarolHu restored the fixMefIssue branch April 20, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants