Reduce the number of intermediary IEnumerables we create while buildind indices #14140

CyrusNajmabadi · 2016-09-28T00:11:25Z

No description provided.

CyrusNajmabadi · 2016-09-28T00:11:38Z

Tagging @dotnet/roslyn-ide @tmeschter

…ng indices.

CyrusNajmabadi · 2016-09-28T01:08:00Z

@jmarolf want to take a look?

benaadams

Extra asyncs?

benaadams · 2016-09-28T01:03:27Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

@@ -117,7 +118,7 @@ public static partial class SymbolFinder
        /// <summary>
        /// Find the declared symbols from either source, referenced projects or metadata assemblies with the specified name.
        /// </summary>
-        public static Task<IEnumerable<ISymbol>> FindDeclarationsAsync(
+        public static async Task<IEnumerable<ISymbol>> FindDeclarationsAsync(


This doesn't need to be made async does it?

benaadams · 2016-09-28T01:04:57Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

            }

-            return FindDeclarationsAsync(project, SearchQuery.Create(name, ignoreCase), SymbolFilter.All, cancellationToken: cancellationToken);
+            return await FindDeclarationsAsync(


Can just return rather than awaiting as before?

benaadams · 2016-09-28T01:05:15Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

            }

-            return FindDeclarationsAsync(project, SearchQuery.Create(name, ignoreCase), filter, cancellationToken: cancellationToken);
+            return await FindDeclarationsAsync(


Can just return rather than awaiting as before?

benaadams · 2016-09-28T01:07:00Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

            }

            using (Logger.LogBlock(FunctionId.SymbolFinder_Project_Name_FindSourceDeclarationsAsync, cancellationToken))
            {
-                return FindSourceDeclarationsAsyncImpl(project, SearchQuery.Create(name, ignoreCase), filter, cancellationToken);
+                return await FindSourceDeclarationsAsyncImpl(


Can just return rather than awaiting as before?

No. The types are not compatible.

benaadams · 2016-09-28T01:07:15Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

@@ -361,7 +389,8 @@ public static Task<IEnumerable<ISymbol>> FindSourceDeclarationsAsync(Project pro
        /// <summary>
        /// Find the symbols for declarations made in source with the specified name.
        /// </summary>
-        public static Task<IEnumerable<ISymbol>> FindSourceDeclarationsAsync(Project project, string name, bool ignoreCase, SymbolFilter filter, CancellationToken cancellationToken = default(CancellationToken))
+        public static async Task<IEnumerable<ISymbol>> FindSourceDeclarationsAsync(


Doesn't need to be async? (as before)

It needs to be async as the types are not compatible.

benaadams · 2016-09-28T01:07:48Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

            Project project, Func<string, bool> predicate, SymbolFilter filter, CancellationToken cancellationToken = default(CancellationToken))
        {
-            return FindSourceDeclarationsAsync(project, SearchQuery.CreateCustom(predicate), filter, cancellationToken);
+            return await FindSourceDeclarationsAsync(


Can just return rather than awaiting as before?

No. The types are not compatible.

benaadams · 2016-09-28T01:08:01Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

@@ -446,13 +476,15 @@ public static Task<IEnumerable<ISymbol>> FindSourceDeclarationsAsync(Project pro
        /// <summary>
        /// Find the symbols for declarations made in source with a matching name.
        /// </summary>
-        public static Task<IEnumerable<ISymbol>> FindSourceDeclarationsAsync(
+        public static async Task<IEnumerable<ISymbol>> FindSourceDeclarationsAsync(


Doesn't need to be async?

It needs to be async as the types are not compatible.

benaadams · 2016-09-28T01:08:32Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

            }

-            return FindDeclarationsAsync(project, SearchQuery.Create(name, ignoreCase), SymbolFilter.All, cancellationToken: cancellationToken);
+            return await FindDeclarationsAsync(


Can just return rather than awaiting as before?

No. The types are not compatible.

benaadams · 2016-09-28T01:08:42Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

            }

-            return FindDeclarationsAsync(project, SearchQuery.Create(name, ignoreCase), filter, cancellationToken: cancellationToken);
+            return await FindDeclarationsAsync(


Can just return rather than awaiting as before?

No. The types are not compatible.

Which types are not compatible?

benaadams · 2016-09-28T01:08:54Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

        }

        /// <summary>
        /// Find the declared symbols from either source, referenced projects or metadata assemblies with the specified name.
        /// </summary>
-        public static Task<IEnumerable<ISymbol>> FindDeclarationsAsync(
+        public static async Task<IEnumerable<ISymbol>> FindDeclarationsAsync(


Doesn't need to be async?

It needs to be async as the types are not compatible.

CyrusNajmabadi · 2016-09-28T02:58:45Z

The asyncs are necessary.

tmeschter · 2016-09-28T19:59:06Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

            }

-            return FindDeclarationsAsync(project, SearchQuery.Create(name, ignoreCase), filter, cancellationToken: cancellationToken);
+            return await FindDeclarationsAsync(


Which types are not compatible?

tmeschter · 2016-09-28T20:01:22Z

src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_Declarations.cs

        }

        private static async Task AddDeclarationsAsync(
            Project project,
            SearchQuery query,
            SymbolFilter filter,
-            List<ISymbol> list,
+            ArrayBuilder<ISymbol> list,


Rename list to builder?

DustinCampbell · 2016-09-28T20:46:48Z

Sorry for the delay. LGTM

dnfclas added the cla-already-signed label Sep 28, 2016

Reduce the number of intermediary IEnumerables we create while buildi…

c78dcf7

…ng indices.

CyrusNajmabadi force-pushed the indexAllocations branch from e8f4523 to c78dcf7 Compare September 28, 2016 00:49

CyrusNajmabadi added 3 commits September 27, 2016 17:50

Remove blank line.

165583a

Reduce more allocations for common paths.

5b5ccba

Prevent boxing.

10db28d

benaadams reviewed Sep 28, 2016

View reviewed changes

CyrusNajmabadi added 4 commits September 27, 2016 20:01

Fix test.

1166fda

Simplify all tests.

73c9776

Make test method non-static.

e15b779

Update tests.

548f47a

tmeschter approved these changes Sep 28, 2016

View reviewed changes

CyrusNajmabadi merged commit 94ef59b into dotnet:master Sep 28, 2016

CyrusNajmabadi deleted the indexAllocations branch September 28, 2016 20:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce the number of intermediary IEnumerables we create while buildind indices #14140

Reduce the number of intermediary IEnumerables we create while buildind indices #14140

CyrusNajmabadi commented Sep 28, 2016

CyrusNajmabadi commented Sep 28, 2016

CyrusNajmabadi commented Sep 28, 2016

benaadams left a comment

benaadams Sep 28, 2016

benaadams Sep 28, 2016

benaadams Sep 28, 2016

benaadams Sep 28, 2016

CyrusNajmabadi Sep 28, 2016

benaadams Sep 28, 2016 •

edited

Loading

CyrusNajmabadi Sep 28, 2016

benaadams Sep 28, 2016

CyrusNajmabadi Sep 28, 2016

benaadams Sep 28, 2016

CyrusNajmabadi Sep 28, 2016

benaadams Sep 28, 2016

CyrusNajmabadi Sep 28, 2016

benaadams Sep 28, 2016

CyrusNajmabadi Sep 28, 2016

tmeschter Sep 28, 2016

benaadams Sep 28, 2016

CyrusNajmabadi Sep 28, 2016

CyrusNajmabadi commented Sep 28, 2016

tmeschter Sep 28, 2016

tmeschter Sep 28, 2016

DustinCampbell commented Sep 28, 2016

Reduce the number of intermediary IEnumerables we create while buildind indices #14140

Reduce the number of intermediary IEnumerables we create while buildind indices #14140

Conversation

CyrusNajmabadi commented Sep 28, 2016

CyrusNajmabadi commented Sep 28, 2016

CyrusNajmabadi commented Sep 28, 2016

benaadams left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benaadams Sep 28, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CyrusNajmabadi commented Sep 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DustinCampbell commented Sep 28, 2016

benaadams Sep 28, 2016 •

edited

Loading