Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop inserting old setup and loc files #13306

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 22, 2016

Stop automatically updating loc and old setup authoring files in lab/ml. These are obsolete and won't be used in Dev15 RTM. If any changes are needed to these files (which would be unexpected) they are they can be done manually.

@tmat
Copy link
Member Author

tmat commented Aug 22, 2016

@dotnet/roslyn-infrastructure @jasonmalinowski @jmarolf

@tmat tmat merged commit 4ca3083 into dotnet:master Aug 23, 2016
@jasonmalinowski
Copy link
Member

@tmat So how is localization working? We're just leaving what every is already inserted there for now, and any changes to assemblies in the mean time need to be updated manually in the internal side?

@jmarolf
Copy link
Contributor

jmarolf commented Aug 23, 2016

@jasonmalinowski the work now falls to me to move all of our loc into the roslyn repro itself.

@tmat
Copy link
Member Author

tmat commented Aug 23, 2016

@jasonmalinowski Localization still works as it used to work. I haven't removed the locproj/lci files from lab/ml. Unless there is a new dll that needs to be localized, is renamed, its location in lab/ml is changed, or adds/removes dependenyc on XAML, there is no need to change these files.

@tmat tmat deleted the SetupLocInsertion branch August 16, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants