Add a /clean option to Restore.cmd #12293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When present this option will clean out all of the NuGet caches before doing a restore. This is necessary to remove our hard coded dependencies on NuGet.exe in our official builds. Once they are removed we can switch to dowloading NuGet.exe on demand vs. checking it into the repo.
|
CC @jasonmalinowski, @tannergooding, @dotnet/roslyn-infrastructure |
| set NuGetAdditionalCommandLineArgs=-verbosity quiet -configfile "%~dp0nuget.config" -Project2ProjectTimeOut 1200 | ||
| set RoslynRoot=%~dp0 | ||
| set NuGetExe="%RoslynRoot%\NuGet.exe" | ||
| set NuGetAdditionalCommandLineArgs=-verbosity quiet -configfile "%RoslynRoot%\nuget.config" -Project2ProjectTimeOut 1200 |
There was a problem hiding this comment.
Not your change, but any idea why we have a timeout for the P2P resolution?
There was a problem hiding this comment.
I have no idea. Maybe @agocke or @tannergooding know.
There was a problem hiding this comment.
Because the default caused them to timeout on us.
|
👍 other than one small question, and that I now have to wash my eyes out after looking at cmd. |
|
test windows_eta_open_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When present this option will clean out all of the NuGet caches before doing a restore.
This is necessary to remove our hard coded dependencies on NuGet.exe in our official builds. Once they are removed we can switch to dowloading NuGet.exe on demand vs. checking it into the repo.