Update Microsoft.DiaSymReader.Native to 1.4.0 RTM #12141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natidea @MattGertz @ManishJayaswal Micro-update fix (internal bug 233397). |
|
LGTM |
jmarolf
pushed a commit
that referenced
this pull request
Jun 30, 2016
* Merge pull request #12041 from heejaechang/buildsyncrace found one more case where documentId can be null * prevent VS from crashing if VS got shutdown while build error reporting is in progress. * Update our NuGet package version to 1.3.2 * Update Microsoft.DiaSymReader.Native to 1.4.0 RTM (#12141) * Enable building of release nuget packages. This commit makes it so that we will always try to generate release nugets except if they depend on prerelease packages. If one of our nuget packages happens to depend on prerelease packages, then when building release nugets, we will simply print a message in the build output and skip release nuget generation for that package (and allow the overall build to succeed). * Address code review feedback. * Simplify script to use nuget.exe for prerelease dependency validation instead of adding custom logic in the script for this. * Remove Microsoft.CodeAnalysis.EditorFeatures from list of prerelease nuget packages. * Change the name of the error log file to skipped_packages.txt. * fixed DifferenceViewer leak this leak was responsible for about 14% of managed memory in customer's dump. basically, in certain condition, if cancellation exception is thrown, we will not close difference viewer which cause all text views to leak. that cause all taggers and text buffers to leak and that cause our preview workspaces to alive. which in turn cause all solutions to alive and so on. all those objects (view, buffer, workspace, solution) are quite big graphs. so ends up eat up 14% of memory. added assert to make sure if we leak viewers again, we get some kind of notification.
jmarolf
pushed a commit
that referenced
this pull request
Jul 1, 2016
* Merge pull request #12041 from heejaechang/buildsyncrace found one more case where documentId can be null * prevent VS from crashing if VS got shutdown while build error reporting is in progress. * Update our NuGet package version to 1.3.2 * Update Microsoft.DiaSymReader.Native to 1.4.0 RTM (#12141) * Enable building of release nuget packages. This commit makes it so that we will always try to generate release nugets except if they depend on prerelease packages. If one of our nuget packages happens to depend on prerelease packages, then when building release nugets, we will simply print a message in the build output and skip release nuget generation for that package (and allow the overall build to succeed). * Address code review feedback. * Simplify script to use nuget.exe for prerelease dependency validation instead of adding custom logic in the script for this. * Remove Microsoft.CodeAnalysis.EditorFeatures from list of prerelease nuget packages. * Change the name of the error log file to skipped_packages.txt. * fixed DifferenceViewer leak this leak was responsible for about 14% of managed memory in customer's dump. basically, in certain condition, if cancellation exception is thrown, we will not close difference viewer which cause all text views to leak. that cause all taggers and text buffers to leak and that cause our preview workspaces to alive. which in turn cause all solutions to alive and so on. all those objects (view, buffer, workspace, solution) are quite big graphs. so ends up eat up 14% of memory. added assert to make sure if we leak viewers again, we get some kind of notification.
jmarolf
pushed a commit
that referenced
this pull request
Jul 3, 2016
* Merge pull request #12041 from heejaechang/buildsyncrace found one more case where documentId can be null * prevent VS from crashing if VS got shutdown while build error reporting is in progress. * Update our NuGet package version to 1.3.2 * Update Microsoft.DiaSymReader.Native to 1.4.0 RTM (#12141) * Enable building of release nuget packages. This commit makes it so that we will always try to generate release nugets except if they depend on prerelease packages. If one of our nuget packages happens to depend on prerelease packages, then when building release nugets, we will simply print a message in the build output and skip release nuget generation for that package (and allow the overall build to succeed). * Address code review feedback. * Simplify script to use nuget.exe for prerelease dependency validation instead of adding custom logic in the script for this. * Remove Microsoft.CodeAnalysis.EditorFeatures from list of prerelease nuget packages. * Change the name of the error log file to skipped_packages.txt. * fixed DifferenceViewer leak this leak was responsible for about 14% of managed memory in customer's dump. basically, in certain condition, if cancellation exception is thrown, we will not close difference viewer which cause all text views to leak. that cause all taggers and text buffers to leak and that cause our preview workspaces to alive. which in turn cause all solutions to alive and so on. all those objects (view, buffer, workspace, solution) are quite big graphs. so ends up eat up 14% of memory. added assert to make sure if we leak viewers again, we get some kind of notification. * Skipping the InteractiveWindow Clipboard UnitTests as they cannot run on VS2015.2
jmarolf
pushed a commit
that referenced
this pull request
Jul 4, 2016
* Merge pull request #12041 from heejaechang/buildsyncrace found one more case where documentId can be null * prevent VS from crashing if VS got shutdown while build error reporting is in progress. * Update our NuGet package version to 1.3.2 * Update Microsoft.DiaSymReader.Native to 1.4.0 RTM (#12141) * Enable building of release nuget packages. This commit makes it so that we will always try to generate release nugets except if they depend on prerelease packages. If one of our nuget packages happens to depend on prerelease packages, then when building release nugets, we will simply print a message in the build output and skip release nuget generation for that package (and allow the overall build to succeed). * Address code review feedback. * Simplify script to use nuget.exe for prerelease dependency validation instead of adding custom logic in the script for this. * Remove Microsoft.CodeAnalysis.EditorFeatures from list of prerelease nuget packages. * Change the name of the error log file to skipped_packages.txt. * fixed DifferenceViewer leak this leak was responsible for about 14% of managed memory in customer's dump. basically, in certain condition, if cancellation exception is thrown, we will not close difference viewer which cause all text views to leak. that cause all taggers and text buffers to leak and that cause our preview workspaces to alive. which in turn cause all solutions to alive and so on. all those objects (view, buffer, workspace, solution) are quite big graphs. so ends up eat up 14% of memory. added assert to make sure if we leak viewers again, we get some kind of notification. * Skipping the InteractiveWindow Clipboard UnitTests as they cannot run on VS2015.2
jmarolf
pushed a commit
that referenced
this pull request
Jul 5, 2016
* Merge pull request #12041 from heejaechang/buildsyncrace found one more case where documentId can be null * prevent VS from crashing if VS got shutdown while build error reporting is in progress. * Update our NuGet package version to 1.3.2 * Update Microsoft.DiaSymReader.Native to 1.4.0 RTM (#12141) * Enable building of release nuget packages. This commit makes it so that we will always try to generate release nugets except if they depend on prerelease packages. If one of our nuget packages happens to depend on prerelease packages, then when building release nugets, we will simply print a message in the build output and skip release nuget generation for that package (and allow the overall build to succeed). * Address code review feedback. * Simplify script to use nuget.exe for prerelease dependency validation instead of adding custom logic in the script for this. * Remove Microsoft.CodeAnalysis.EditorFeatures from list of prerelease nuget packages. * Change the name of the error log file to skipped_packages.txt. * fixed DifferenceViewer leak this leak was responsible for about 14% of managed memory in customer's dump. basically, in certain condition, if cancellation exception is thrown, we will not close difference viewer which cause all text views to leak. that cause all taggers and text buffers to leak and that cause our preview workspaces to alive. which in turn cause all solutions to alive and so on. all those objects (view, buffer, workspace, solution) are quite big graphs. so ends up eat up 14% of memory. added assert to make sure if we leak viewers again, we get some kind of notification. * Skipping the InteractiveWindow Clipboard UnitTests as they cannot run on VS2015.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.