Ensure that we respect source suppressions for IDE analyzer diagnosti… #11343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heejaechang @dotnet/roslyn-analysis can you please review? |
|
Ping |
| _updateSource.UpdateDiagnosticsForProject(projectId, Tuple.Create(s_analyzerChangedErrorId, analyzerPath), SpecializedCollections.SingletonEnumerable(data)); | ||
| var messageArguments = new string[] { analyzerPath }; | ||
| var diagnostic = await DiagnosticData.CreateAsync(_analyzerChangedRule, messageArguments, projectId, _workspace, CancellationToken.None).ConfigureAwait(false); | ||
| _updateSource.UpdateDiagnosticsForProject(projectId, Tuple.Create(s_analyzerChangedErrorId, analyzerPath), SpecializedCollections.SingletonEnumerable(diagnostic)); |
There was a problem hiding this comment.
is it okay to be async now? and order of event become changed? for example, it raised event (but not registered to update source yet) but before that happens, solution is closed and then it is registered to update source.
|
left some comment, I think isSuppressed argument is a bit weird since diagnostic and issuppressed can be 2 different value given by users. |
…cs (analyzer dependency errors, reading ruleset errors, etc.) Fixes dotnet#8877
|
@heejaechang Thanks. I have addressed your feedback and it should be much cleaner now. |
|
@heejaechang Does the new changes look good? |
| { | ||
| // Get diagnostic with effective severity. | ||
| // Additionally, if the diagnostic was suppressed by a source suppression, effectiveDiagnostics will have a diagnostic with IsSuppressed = true. | ||
| var compilation = project.GetCompilationAsync(cancellationToken).WaitAndGetResult(cancellationToken); |
There was a problem hiding this comment.
Not sure, but all the current callsites are sync. We can revisit in future.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cs (analyzer dependency errors, reading ruleset errors, etc.)
Fixes #8877