Fixed Stream sample in Additional files documentation #10976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code had two issues:
StreamWriter
closes the underlyingMemoryStream
, soXDocument
can't read from it.MemoryStream
stays at its end, soXDocument
wouldn't read anything.This change fixes both issues.
I have also mentioned converting to
string
usingToString
in the description before the example. Though IMHO, in this specific case, callingToString()
and then usingXDocument.Parse()
instead would be preferable.