Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable VS-threading analyzers. #29275

Closed
5 tasks
sharwell opened this issue Aug 14, 2018 · 1 comment
Closed
5 tasks

Enable VS-threading analyzers. #29275

sharwell opened this issue Aug 14, 2018 · 1 comment
Labels
Area-IDE Concept-Continuous Improvement
Milestone
Backlog

Comments

@sharwell
Copy link
Member

sharwell commented Aug 14, 2018 •
edited by CyrusNajmabadi
Loading

From #28781:

This diagnostic is enabled, but its accuracy relies heavily on configuration files provided separately. The configuration for VSSDK types ships with the VSSDK analyzers, which are not yet enabled for the full Roslyn build.

  • VSTHRD010 (Invoke single-threaded types on Main thread)
  • VSTHRD200 (Use "Async" suffix for async methods)
  • VSTHRD103 (Call async methods when in an async method)
  • VSTHRD002 (Avoid problematic synchronous waits)
  • VSTHRD003 (Avoid awaiting foreign Tasks)
@jinujoseph jinujoseph modified the milestones: Unknown, 16.0 Aug 16, 2018
sharwell added a commit to sharwell/roslyn that referenced this issue Sep 13, 2018
@sharwell
Disable VSTHRD010 to improve build performance
48a9ae5 
We are not currently using this analyzer to its full extent since it
requires repository-specific configuration which is not yet provided for
Roslyn. Issue dotnet#29275 tracks configuring and enabling this analyzer.
@jinujoseph jinujoseph modified the milestones: 16.0, 16.1 Jan 16, 2019
@jinujoseph jinujoseph modified the milestones: 16.1, Backlog Apr 24, 2019
@CyrusNajmabadi CyrusNajmabadi changed the title Enable VSTHRD010 (Invoke single-threaded types on Main thread) Enable VS-threading analyzers. Nov 2, 2022
This was referenced Nov 2, 2022
Closed
Closed
Closed
Closed
@CyrusNajmabadi
Copy link
Member

Closing out as speculative. If we want to do this, it should be assigned to a dev/milestone.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jaredpar @sharwell @CyrusNajmabadi @jinujoseph