Skip to content

Commit

Permalink
Change PR Val builds to be unsigned (#76358)
Browse files Browse the repository at this point in the history
Disables signing for build artifacts to improve the turn around time for
getting results back from a validation run.

Measuring from `SignToolTask starting` to `SignToolTask execution
finished`.
- Real signing: varies but is a whole lotta time (could be over an hour)
- Test signing: ~7min
- No signing: <1sec

Test Run:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10705817&view=results
(microsoft)
  • Loading branch information
JoeRobich authored Dec 13, 2024
2 parents fe3a243 + dc71f98 commit 2eca5b2
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
2 changes: 2 additions & 0 deletions azure-pipelines-pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ variables:
value: false
- name: Codeql.SkipTaskAutoInjection
value: true
- name: SignType
value: ''

# To retrieve OptProf data we need to authenticate to the VS drop storage.
# If the pipeline is running in DevDiv, the account has access to the VS drop storage.
Expand Down
15 changes: 15 additions & 0 deletions eng/Signing.props
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,19 @@
<FileSignInfo Include="Microsoft.VisualStudio.Threading.dll" CertificateName="MicrosoftSHA2" />
<FileSignInfo Include="StreamJsonRpc.dll" CertificateName="MicrosoftSHA2" />
</ItemGroup>

<!--
We do not intend to ship the artifacts produced for PR validation build so we can skip signing the artifacts.
-->
<Choose>
<When Condition="'$(PreReleaseVersionLabel)' == 'pr-validation' And '$(SignType)' == ''">
<ItemGroup>
<ItemsToSign Remove="@(ItemsToSign)" />
</ItemGroup>

<PropertyGroup>
<AllowEmptySignList>true</AllowEmptySignList>
</PropertyGroup>
</When>
</Choose>
</Project>

0 comments on commit 2eca5b2

Please sign in to comment.