Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer and fixer that recommend case insensitive string comparison #6662

Merged
merged 47 commits into from
Jun 20, 2023
Merged

Analyzer and fixer that recommend case insensitive string comparison #6662

merged 47 commits into from
Jun 20, 2023

Commits on May 31, 2023

  1. Resources and documentation

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c9b4479 View commit details
    Browse the repository at this point in the history

  2. Analyzer

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d85c6a8 View commit details
    Browse the repository at this point in the history

  3. Fixer

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    ab3965f View commit details
    Browse the repository at this point in the history

  4. Base test class

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    9516781 View commit details
    Browse the repository at this point in the history

  5. C# tests

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1a407d4 View commit details
    Browse the repository at this point in the history

  6. VisualBasic tests

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5d202a2 View commit details
    Browse the repository at this point in the history

  7. Address suggestion: Inline localizable strings that are used only once.

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    27acb1c View commit details
    Browse the repository at this point in the history

  8. Address suggestion: Prefer GetSpecialType for string.

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4298b5c View commit details
    Browse the repository at this point in the history

  9. Use explicit.

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d6a193c View commit details
    Browse the repository at this point in the history

  10. Do not pass argument to diagnostic that does not need it.

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    2ca2441 View commit details
    Browse the repository at this point in the history

  11. Address suggestion: Use Length instead of Count()

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c441153 View commit details
    Browse the repository at this point in the history

  12. Address suggestion: Improve name of caseChangingMethodName

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8de0cd9 View commit details
    Browse the repository at this point in the history

  13. Address suggestion: Remove token cancellation handling code

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4da0528 View commit details
    Browse the repository at this point in the history

  14. Address suggestion: Remove unused cancellation token argument.

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0011a6a View commit details
    Browse the repository at this point in the history

  15. Address suggestion: Add missing fixer attribute, seal class

    @carlossanlop
    carlossanlop committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0bfbc0b View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Analyzer: Remove unused using.

    @carlossanlop
    carlossanlop committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    5c16a10 View commit details
    Browse the repository at this point in the history

  2. Address suggestion: Use better test pattern. Simplify tests.

    @carlossanlop
    carlossanlop committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    492275d View commit details
    Browse the repository at this point in the history

  3. More tests

    @carlossanlop
    carlossanlop committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1098548 View commit details
    Browse the repository at this point in the history

  4. Address suggestion: Await tests.

    @carlossanlop
    carlossanlop committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1a2f5ec View commit details
    Browse the repository at this point in the history

  5. Fix spacing warning

    @carlossanlop
    carlossanlop committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1617027 View commit details
    Browse the repository at this point in the history

  6. Handle all 3 IndexOf overloads that can be converted to the StringCom… 

    …parison overload.
    @carlossanlop
    carlossanlop committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    75109c0 View commit details
    Browse the repository at this point in the history

  7. Address suggestion: Walk up parenthesized operations

    @carlossanlop
    carlossanlop committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    0de635c View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Add "No diagnostic" tests

    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    a5e4f97 View commit details
    Browse the repository at this point in the history

  2. Do not fix CompareTo, only suggest.

    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f8d5688 View commit details
    Browse the repository at this point in the history

  3. Remove unused CompareTo fixer code and fix some warnings.

    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    5961fab View commit details
    Browse the repository at this point in the history

  4. Add missing entry for second variant of diagnostic rule message in "R… 

    …ulesMissingDocumentation.md".
    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    fee0f45 View commit details
    Browse the repository at this point in the history

  5. Revert md and sarif changes to fix CI

    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    fb4f324 View commit details
    Browse the repository at this point in the history

  6. Address suggestion: Use WalkUpParentheses

    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    673d04c View commit details
    Browse the repository at this point in the history

  7. Add short string for the codefix CodeAction title

    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    349a06c View commit details
    Browse the repository at this point in the history

  8. Consume codefix CodeAction short string in title

    @carlossanlop
    carlossanlop committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    dd47ee2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Fix CI

    @carlossanlop
    carlossanlop committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    59c0115 View commit details
    Browse the repository at this point in the history

  2. Remove some unnecessary fixer code

    @carlossanlop
    carlossanlop committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    21cfaaf View commit details
    Browse the repository at this point in the history

  3. Use better equivalenceKey

    @carlossanlop
    carlossanlop committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    cb83e9e View commit details
    Browse the repository at this point in the history

  4. Diagnose inverted pattern

    @carlossanlop
    carlossanlop committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    d73eb5c View commit details
    Browse the repository at this point in the history

  5. Tests for named arguments

    @carlossanlop
    carlossanlop committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    7ede45e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Change resources to be able to address named parameters

    @carlossanlop
    carlossanlop committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ea7d45d View commit details
    Browse the repository at this point in the history

  2. src: Address named parameters

    @carlossanlop
    carlossanlop committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    f37c39e View commit details
    Browse the repository at this point in the history

  3. tests: Adjust tests to verify named parameters

    @carlossanlop
    carlossanlop committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    3f7a020 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Move ExportCodeFixProvider and Shared attributes to derived types.

    @carlossanlop
    carlossanlop committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    801fb99 View commit details
    Browse the repository at this point in the history

  2. public sealed fixers

    @carlossanlop
    carlossanlop committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    84745f0 View commit details
    Browse the repository at this point in the history

  3. Improved resource description mentioning allocation. Use single quote… 

    …s, minor spacing.
    @carlossanlop
    carlossanlop committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2d3cf5b View commit details
    Browse the repository at this point in the history

  4. Remove commented code

    @carlossanlop
    carlossanlop committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    986973c View commit details
    Browse the repository at this point in the history

  5. Update xlfs

    @carlossanlop
    carlossanlop committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    0a2182e View commit details
    Browse the repository at this point in the history

  6. Remove commented code

    @carlossanlop
    carlossanlop committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4778992 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Rename to GetNewArguments

    @carlossanlop
    carlossanlop committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e2b4b95 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge remote-tracking branch 'dotnet/main' into RecommendCaseInsensit… 

    …iveStringComparison
    @carlossanlop
    carlossanlop committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e570710 View commit details
    Browse the repository at this point in the history

  2. Fix build

    @carlossanlop
    carlossanlop committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    efabebc View commit details
    Browse the repository at this point in the history