Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConstructorParamShouldMatchPropNames analyzer #4877

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Add ConstructorParamShouldMatchPropNames analyzer #4877

wants to merge 64 commits into from

Commits on Feb 22, 2021

  1. Add ConstructorParamShouldMatchPropNames analyzer

    @psxvoid
    psxvoid committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    3dedbb2 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Fix - remove unused package reference

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    6dc3ef9 View commit details
    Browse the repository at this point in the history

  2. Fix json-ctor order in well-known-names

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    6b71577 View commit details
    Browse the repository at this point in the history

  3. Fix code alignment in tests

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    52360bb View commit details
    Browse the repository at this point in the history

  4. Mark the diagnostic as non-fx-cop-ported

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d9308a4 View commit details
    Browse the repository at this point in the history

  5. Add missing msbuild autogenerated assets

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    700c4ac View commit details
    Browse the repository at this point in the history

  6. Fix - remove unused package reference, part 2

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d3769d6 View commit details
    Browse the repository at this point in the history

  7. Update rule's message

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    5c82803 View commit details
    Browse the repository at this point in the history

  8. Rollback unrelated analyzer to the original state

    @psxvoid
    psxvoid committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    43ad9b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Update the description message for the analyzer

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    41d44b2 View commit details
    Browse the repository at this point in the history

  2. Fix misplaced comma and update the message

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    e3db946 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect helper test method name prefix

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    e9bc939 View commit details
    Browse the repository at this point in the history

  4. Update the message title with the recommended one

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    481f5ed View commit details
    Browse the repository at this point in the history

  5. Use net50 references instead netstandard20 in tests

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    93c0429 View commit details
    Browse the repository at this point in the history

  6. Replace IsJsonCtor extension-method with private method

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    3efee13 View commit details
    Browse the repository at this point in the history

  7. Rename the analyzer - add "field" in its name

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    2b49119 View commit details
    Browse the repository at this point in the history

  8. Remove unused using in tests

    @psxvoid
    psxvoid committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    c2051bf View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. Replace banned-API with non-banned in tests

    @psxvoid
    psxvoid committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    e9aa041 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Add a code fix provider, partially tested with C#

    @psxvoid
    psxvoid committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    9579d93 View commit details
    Browse the repository at this point in the history

  2. [POC] Verify tuple assignment is working with CA1071

    @psxvoid
    psxvoid committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    5a62547 View commit details
    Browse the repository at this point in the history

  3. Revert "[POC] Verify tuple assignment is working with CA1071" 

    This reverts commit 5a62547.
    @psxvoid
    psxvoid committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    33dccdd View commit details
    Browse the repository at this point in the history

  4. Add C# tests for classes with fields and props

    @psxvoid
    psxvoid committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    57437ba View commit details
    Browse the repository at this point in the history

  5. Add VB tests for classes with fields and props

    @psxvoid
    psxvoid committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    727423b View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. The analyzer - ensure bound properties are public

    @psxvoid
    psxvoid committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    6c83c6e View commit details
    Browse the repository at this point in the history

  2. Fix minor dis-alignment in tests

    @psxvoid
    psxvoid committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    2482c4c View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Fix tuple assignment reference not detected

    @psxvoid
    psxvoid committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    d4bec8b View commit details
    Browse the repository at this point in the history

  2. Simplify member reference retrieval

    @psxvoid
    psxvoid committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    9089e0a View commit details
    Browse the repository at this point in the history

  3. Merge reference symbol null and static checks

    @psxvoid
    psxvoid committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5aff394 View commit details
    Browse the repository at this point in the history

  4. Rename local variable in member reference retrival

    @psxvoid
    psxvoid committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5fba883 View commit details
    Browse the repository at this point in the history

  5. Add tuple assignment test for records

    @psxvoid
    psxvoid committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    cd373f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Analyzer - group tests for records below tests for classes

    @psxvoid
    psxvoid committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    1fb8c27 View commit details
    Browse the repository at this point in the history

  2. Analyzer - sort tests for classes

    @psxvoid
    psxvoid committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    da07af5 View commit details
    Browse the repository at this point in the history

  3. Analyzer - ensure bound fields are public

    @psxvoid
    psxvoid committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    0c3e2a9 View commit details
    Browse the repository at this point in the history

  4. Fix parameter alignment in analyzer tests

    @psxvoid
    psxvoid committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    2309cb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Analyzer - add tests for private fields with JsonInclude

    @psxvoid
    psxvoid committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7285658 View commit details
    Browse the repository at this point in the history

  2. Analyzer - add tests with JsonPropertyName

    @psxvoid
    psxvoid committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    52dce8e View commit details
    Browse the repository at this point in the history

  3. Analyzer - report unreferenced params (no messages)

    @psxvoid
    psxvoid committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c603b66 View commit details
    Browse the repository at this point in the history

  4. Analyzer - add messages for unreferenced parameters

    @psxvoid
    psxvoid committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    afb760a View commit details
    Browse the repository at this point in the history

  5. Analyzer - free unused parameter set on symbol-end

    @psxvoid
    psxvoid committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4d30c8f View commit details
    Browse the repository at this point in the history

  6. Analyzer - sort methods by visibility and logically

    @psxvoid
    psxvoid committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    641721d View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Analyzer - fix reversed words match (should not)

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    65ea1ad View commit details
    Browse the repository at this point in the history

  2. Analyzer - add regions, cleanup and organize tests

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    defb3c2 View commit details
    Browse the repository at this point in the history

  3. Analyzer - simplify return in ShouldAnalyzerMethod

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    d4345d5 View commit details
    Browse the repository at this point in the history

  4. Analyzer - simplify supported members matching

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    2008be6 View commit details
    Browse the repository at this point in the history

  5. Add TODO - referenced members are not static diagnostic

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    c0687c6 View commit details
    Browse the repository at this point in the history

  6. Analyzer - format compilation start action registration

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    313bdfd View commit details
    Browse the repository at this point in the history

  7. Analyzer - merge name match logic into a single method

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    fa0fd41 View commit details
    Browse the repository at this point in the history

  8. Add "key" postfix to diagnostic parameter keys

    @psxvoid
    psxvoid committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    4d4a1ec View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Analyzer - remove unused parameter analysis

    @psxvoid
    psxvoid committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    e059159 View commit details
    Browse the repository at this point in the history

  2. Analyzer - init using scoped context variable

    @psxvoid
    psxvoid committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    a95f803 View commit details
    Browse the repository at this point in the history

  3. Analyzer - fix build: invalid whitespace in tests

    @psxvoid
    psxvoid committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1e62744 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Analyzer - inline ExportFixProvider and Shared attributes 

    Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
    @psxvoid @buyaa-n
    psxvoid and buyaa-n committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    1e1d382 View commit details
    Browse the repository at this point in the history

  2. Revert "Analyzer - inline ExportFixProvider and Shared attributes" 

    This reverts commit 1e1d382.
    @psxvoid
    psxvoid committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    9a727e4 View commit details
    Browse the repository at this point in the history

  3. Fixer - inline ExportFixProvider and Shared attributes (fixed)

    @psxvoid
    psxvoid committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    8dacfcb View commit details
    Browse the repository at this point in the history

  4. Analyzer - use single diagnostic rule per analyzer

    @psxvoid
    psxvoid committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ab492ca View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. CodeFix - make bound field public (no message, not aligned)

    @psxvoid
    psxvoid committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    b1deb98 View commit details
    Browse the repository at this point in the history

  2. Analyzer - remove unreferenced parameter diagnostic reason

    @psxvoid
    psxvoid committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    2008bfe View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Analyzer - fix broken tests due to additional diagnostic location

    @psxvoid
    psxvoid committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    194c3a2 View commit details
    Browse the repository at this point in the history

  2. CodeFix - add tests for single private property

    @psxvoid
    psxvoid committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    a487621 View commit details
    Browse the repository at this point in the history

  3. CodeFix - add tests for multiple private fields and props

    @psxvoid
    psxvoid committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    f38390d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Analyzer - use "Add" instead of "SetItem"

    @psxvoid
    psxvoid committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    051d067 View commit details
    Browse the repository at this point in the history

  2. Analyzer - init jsonConstructorAttribute symbol using out var

    @psxvoid
    psxvoid committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    f86bf43 View commit details
    Browse the repository at this point in the history

  3. Analyzer - Use ContainingType.Name instead of ToDisplayString

    @psxvoid
    psxvoid committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    35b2346 View commit details
    Browse the repository at this point in the history

  4. Analyzer - Remove parentheses from lambda param while passing context

    @psxvoid
    psxvoid committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    aafe0de View commit details
    Browse the repository at this point in the history