Update CA1820 to not report on expression trees #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Dec 21, 2020
| public static bool IsWithinLambdaOrLocalFunction(this IOperation operation, [NotNullWhen(true)] out IOperation? containingLambdaOrLocalFunctionOperation) | ||
| { | ||
| containingLambdaOrLocalFunctionOperation = operation.GetAncestor(s_LambdaAndLocalFunctionKinds); | ||
| return containingLambdaOrLocalFunctionOperation != null; | ||
| } | ||
|
|
||
| public static bool IsWithinExpressionTree(this IOperation operation, | ||
| [NotNullWhen(true)] INamedTypeSymbol? linqExpressionTreeType) |
There was a problem hiding this comment.
I have seen two different approaches in the codebase and I am not sure which one is the preferred one:
- Take the named type
- Take the compilation and retrieve the named type from within the helper
Codecov Report
@@ Coverage Diff @@
## master #4621 +/- ##
==========================================
- Coverage 95.77% 95.77% -0.01%
==========================================
Files 1193 1193
Lines 269067 269095 +28
Branches 16245 16248 +3
==========================================
+ Hits 257706 257718 +12
- Misses 9278 9283 +5
- Partials 2083 2094 +11 |
mavasani
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1508