-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port semantic tokens range endpoint to cohost server #9761
Merged
davidwengier
merged 12 commits into
features/cohost
from
dev/dawengie/SemanticTokensCohost
Dec 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5819e8c
Use constructor injection
davidwengier 93f886d
Use primary constructor
davidwengier c44a260
Move logic from endpoint into service
davidwengier de081ab
Move IClientConnection to a parameter to prepare for cohosting
davidwengier 0755188
Use primary constructor
davidwengier d216f26
Create cohost endpoint
davidwengier 0e6bd17
Disable semantic tokens in regular server
davidwengier 16615ce
Move options retreival code out into the endpoints
davidwengier 0e9d0b3
Update tests and benchmarks
davidwengier 7f258ab
Merge branch 'features/cohost' into dev/dawengie/SemanticTokensCohost
davidwengier bf504f3
Updates after merge
davidwengier ad2fe27
Merge branch 'features/cohost' into dev/dawengie/SemanticTokensCohost
davidwengier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there is no else case for this
if (!featureOptions.UseRazorCohostServer)
condition,I wonder where is the cohost setup happening and why we don't add
IRazorSemanticTokensInfoService
for whenUseRazorCohostServer
is set totrue
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cohosting uses MEF for DI, so the setup is all done via attributes and not by manually adding things to service collections