Support "Generate Event Handler" on event callbacks (ie ValueChanged and friends)
#11347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already know it anyway, and means less specialization in the receiver
ryzngard
approved these changes
Jan 2, 2025
| } | ||
|
|
||
| // TypeName is something like "EventCallback<System.String>", so we need to parse out the parameter type. | ||
| if (ComponentAttributeIntermediateNode.TryGetEventCallbackArgument(attribute.TypeName.AsMemory(), out var argument)) |
There was a problem hiding this comment.
(not related to this pr)
me: Why is this memory?
also me: ohh... why does that function take memory instead of a span?
There was a problem hiding this comment.
Compiler team: Chasing perf at all costs!
Tooling team: .ToString() all the things, and then serialize them to Json just in case!
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9730
Fixes #10704
Commit at a time might be easier, depending on how well GitHub handlers the diff