Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tooling MvcShims #11088

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Conversation

DustinCampbell
Copy link
Member

Thanks to recent changes made by @jjonescz, this pull request moves lots of unused and unnecessary code from tooling, getting rid of MvcShims in the tooling layer.

Due to the number of files change, I strongly recommend reviewing commit by commit.

These methods were the only thing using types from Microsoft.AspNetCore.Razor.Test.ComponentShim, and they weren't even being used!
The MvcShims defined in tooling are only refernced in the projects located in "src\Razor\test\testapps". However, those projects don't appear to actually ever be built by anything. The source files in the "testapps" projects are used by some of the tooling benchmarks, but that usage doesn't require us to continue building the shims.
@DustinCampbell DustinCampbell requested review from a team as code owners October 24, 2024 23:23
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much red 😍

Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the easy to read commits <3

Copy link
Member

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@DustinCampbell
Copy link
Member Author

@dotnet/razor-compiler: I'm going to go ahead and merge this PR. It doesn't contain any production code changes and just removes code that the compiler doesn't use anymore.

@DustinCampbell DustinCampbell merged commit 45b65b3 into dotnet:main Oct 25, 2024
12 checks passed
@DustinCampbell DustinCampbell deleted the remove-tooling-shims branch October 25, 2024 17:10
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 25, 2024
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.13 P1 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants