-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tooling MvcShims #11088
Remove tooling MvcShims #11088
Conversation
These methods were the only thing using types from Microsoft.AspNetCore.Razor.Test.ComponentShim, and they weren't even being used!
The MvcShims defined in tooling are only refernced in the projects located in "src\Razor\test\testapps". However, those projects don't appear to actually ever be built by anything. The source files in the "testapps" projects are used by some of the tooling benchmarks, but that usage doesn't require us to continue building the shims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much red 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the easy to read commits <3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
@dotnet/razor-compiler: I'm going to go ahead and merge this PR. It doesn't contain any production code changes and just removes code that the compiler doesn't use anymore. |
Thanks to recent changes made by @jjonescz, this pull request moves lots of unused and unnecessary code from tooling, getting rid of MvcShims in the tooling layer.
Due to the number of files change, I strongly recommend reviewing commit by commit.