Remove tooling MvcShims #11088
Merged
Remove tooling MvcShims #11088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods were the only thing using types from Microsoft.AspNetCore.Razor.Test.ComponentShim, and they weren't even being used!
The MvcShims defined in tooling are only refernced in the projects located in "src\Razor\test\testapps". However, those projects don't appear to actually ever be built by anything. The source files in the "testapps" projects are used by some of the tooling benchmarks, but that usage doesn't require us to continue building the shims.
ryzngard
approved these changes
Oct 24, 2024
|
@dotnet/razor-compiler: I'm going to go ahead and merge this PR. It doesn't contain any production code changes and just removes code that the compiler doesn't use anymore. |
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to recent changes made by @jjonescz, this pull request moves lots of unused and unnecessary code from tooling, getting rid of MvcShims in the tooling layer.
Due to the number of files change, I strongly recommend reviewing commit by commit.