Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup default RemoteAutoInsertOptions #10852

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Cleanup default RemoteAutoInsertOptions #10852

merged 4 commits into from
Sep 10, 2024

Conversation

alexgav
Copy link
Contributor

@alexgav alexgav commented Sep 6, 2024

Use default RazorFormattingOptions constructor in init of RemoteAutoInsertOptions to avoid having potentially two sets of defaults.

@alexgav alexgav requested a review from a team as a code owner September 6, 2024 22:48
@alexgav alexgav mentioned this pull request Sep 6, 2024
Merged
davidwengier
davidwengier approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow up. The removal of any LSP protocol using statements from a class in the workspaces layer is a great indication of why this is a nicer API :)

(I agree with Dustin's comment about whitespace :P)

@alexgav alexgav enabled auto-merge (squash) September 7, 2024 12:18
@alexgav alexgav merged commit d8b0c49 into main Sep 10, 2024
12 checks passed
@alexgav alexgav deleted the dev/alexgav/CleanupFormattingOptionsCreation branch September 10, 2024 23:23
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 10, 2024
This was referenced Sep 12, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@ryzngard ryzngard ryzngard approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
4 participants
@alexgav @DustinCampbell @ryzngard @davidwengier