Change UseConsolidatedMvcViews to default to true #10795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/razor-compiler for review please |
333fred
approved these changes
Aug 27, 2024
ryzngard
approved these changes
Aug 27, 2024
DustinCampbell
approved these changes
Aug 27, 2024
jjonescz
approved these changes
Aug 28, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseConsolidatedMvcViewsdetermines the namespace and visibility of generated MVC view classes. The source generator unconditionally setsUseConsolidatedMvcViewsto true. The only time actual on-disk code is emitted with it false is when a user has disabled the source generator and is using RZC, which produces a separate views assembly.The IDE Tooling uses whatever is set as default. That means that for the vast majority of customers the visibility of the compiler generated code and the tooling generated code is different. This flips the default to
trueso that tooling most often matches what the user is actually producing.Matching SDK fix: dotnet/sdk#43037
Fixes: #9352