Self-versioned documents #10747
Self-versioned documents #10747
Conversation
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/GeneratedDocumentSynchronizer.cs
Show resolved
Hide resolved
davidwengier
force-pushed
the
dev/dawengie/SelfVersionedDocumentSnapshots
branch
4 times, most recently
from
d8a4db3
to
92743cc
Compare
fixup semantic tokens tweask
davidwengier
force-pushed
the
dev/dawengie/SelfVersionedDocumentSnapshots
branch
from
92743cc
to
374e85c
Compare
Note that I won't give a checkmark (nor should anyone else, honestly 😄) for a draft PR. Happy to leave early feedback though. |
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DocumentState.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/IDocumentSnapshot.cs
Show resolved
Hide resolved
...oft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget.cs
Outdated
Show resolved
Hide resolved
...nguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget_UpdateCSharpBuffer.cs
Outdated
Show resolved
Hide resolved
...zor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/GeneratedDocumentSynchronizerTest.cs
Show resolved
Hide resolved
src/Razor/test/Microsoft.CodeAnalysis.Razor.Workspaces.Test/ProjectSystem/ProjectStateTest.cs
Outdated
Show resolved
Hide resolved
...or/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/ProjectSystem/TestDocumentSnapshot.cs
Outdated
Show resolved
Hide resolved
...or/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/ProjectSystem/TestDocumentSnapshot.cs
Outdated
Show resolved
Hide resolved
...o.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget_SemanticTokens.cs
Outdated
Show resolved
Hide resolved
...oft.VisualStudio.LanguageServices.Razor/LanguageClient/Endpoints/RazorCustomMessageTarget.cs
Outdated
Show resolved
Hide resolved
|
Should have taken this out of draft a few days ago, sorry. I do still want to get an integration test run with for it though |
…rsionedDocumentSnapshots
| @@ -55,7 +55,7 @@ public TextDocumentIdentifier GetTextDocumentIdentifier(FoldingRangeParams reque | |||
|
|
|||
| var requestParams = new RazorFoldingRangeRequestParam | |||
| { | |||
| HostDocumentVersion = documentContext.Version, | |||
| HostDocumentVersion = documentContext.Snapshot.Version, | |||
There was a problem hiding this comment.
I can't tell from diff why we need to get version from Snapshot
There was a problem hiding this comment.
Simply because that's where it is now. It used to be on DocumentContext by way of DocumentVersionCache, but the version cache has been deleted and each document snapshot is responsible for its own version number now.
…rsionedDocumentSnapshots # Conflicts: # src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/DocumentContextExtensions.cs
…use only we understand our version numbers
|
Integration tests work! Found a bug in code actions from the integration tests, which was also present in the presentation endpoints. And a slight whoopsy in our code action telemetry, which I didn't introduce, but I fixed because I'm nice like that 😛 Running another round of integration tests, and then will have to consider merging, versus holding off until after the snap. |
| if (previouslyPublishedData.HostDocumentVersion > hostDocumentVersion) | ||
| { | ||
| // We've already published a newer version of this document. No-op. | ||
| Debug.Fail("Html document being published that is older than one we've previously published!"); |
There was a problem hiding this comment.
@ryzngard reports that removing this line (and the equiv for C#) fixes issues in VS Code, so this bears removal, and subsequent investigation
|
Alright, I'm merging. Let the chips fall where they may. |
A few integration tests to investigate, but the guts are here.
I'm slightly worried this might cause us to recompile files more often, but there is also the chance this fixes a bunch of bugs by recompiling files more often :)
Commit-at-a-time review is highly recommended, as there are lots of flow on effects of API changes