Clean up extension methods in MS.CA.Razor.Workspaces #10670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
GitHub borked on this PR, so I don't know that I got all of it, but I saw the important parts.
My only feedback is bikeshedding the meaning of words like "Collapsed" and "Empty", and whether we can just remove logging. I've been converting one of the document mapping methods from TextEdit to TextChange, and thats what I've been doing as I've been creating/modifying these sorts of extension methods.
Love the change overall though, and very excited to resolve the conflicts in my current branch 😁
...osoft.AspNetCore.Razor.LanguageServer/CodeActions/Razor/CreateComponentCodeActionResolver.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/LinePositionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/ProjectExtensions.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/RazorCodeDocumentExtensions.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/VsLspExtensions_Range.cs
Outdated
Show resolved
Hide resolved
...oft.VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostSignatureHelpEndpoint.cs
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I started looking at co-hosting support for Go to Definition, I noticed that our extension methods for working with LSP types had started to grow out of control. This is even more awkward now, since we've got two sets of LSP types in Razor for co-hosting: Microsoft.VisualStudio.LanguageService.Protocol and Roslyn.LanguageService.Protocol.
My commit history starts out helpful, but by the end, the commits are quite a bit bigger as they focus specifically on LSP extensions and updating relevant calling code.