Minor updates for Razor repo #10576
Merged
Minor updates for Razor repo #10576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests run in lab and passed. |
DustinCampbell
approved these changes
Jul 3, 2024
Directory.Packages.props
Outdated
| @@ -120,7 +120,7 @@ | |||
| <PackageVersion Include="xunit" Version="$(_XunitPackageVersion)" /> | |||
| <PackageVersion Include="Xunit.Combinatorial" Version="1.5.25" /> | |||
| <PackageVersion Include="xunit.extensibility.execution" Version="$(_XunitPackageVersion)" /> | |||
| <PackageVersion Include="xunit.runner.utility" Version="2.4.1" /> | |||
| <PackageVersion Include="xunit.runner.utility" Version="$(_XunitPackageVersion)" /> | |||
There was a problem hiding this comment.
I haven't looked, but is _XunitPackageVersion >= 2.4.1?
There was a problem hiding this comment.
Currently 2.6.3 by the look of things
chsienki
approved these changes
Jul 3, 2024
davidwengier
approved these changes
Jul 3, 2024
| @@ -103,10 +103,10 @@ | |||
| <PackageVersion Include="Microsoft.WebTools.Languages.Shared.Editor" Version="$(_MicrosoftWebToolsPackageVersion)" /> | |||
| <PackageVersion Include="Microsoft.WebTools.Languages.Shared.VS" Version="$(_MicrosoftWebToolsPackageVersion)" /> | |||
| <PackageVersion Include="Microsoft.WebTools.Shared" Version="$(_MicrosoftWebToolsPackageVersion)" /> | |||
| <PackageVersion Include="Moq" Version="4.16.0" /> | |||
| <PackageVersion Include="Moq" Version="4.18.4" /> | |||
There was a problem hiding this comment.
In case anyone was wondering, like me, version 4.20 was the first version with sponsor link, and 4.20.69 doens't have sponsor link. So this version is fine.
Directory.Packages.props
Outdated
| @@ -120,7 +120,7 @@ | |||
| <PackageVersion Include="xunit" Version="$(_XunitPackageVersion)" /> | |||
| <PackageVersion Include="Xunit.Combinatorial" Version="1.5.25" /> | |||
| <PackageVersion Include="xunit.extensibility.execution" Version="$(_XunitPackageVersion)" /> | |||
| <PackageVersion Include="xunit.runner.utility" Version="2.4.1" /> | |||
| <PackageVersion Include="xunit.runner.utility" Version="$(_XunitPackageVersion)" /> | |||
There was a problem hiding this comment.
Currently 2.6.3 by the look of things
jjonescz
approved these changes
Jul 4, 2024
phil-allen-msft
force-pushed
the
dev/phil-allen-msft/minorupdates
branch
from
48af27d to
f028e04
Compare
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update packages referenced
Update away from former nation name