Fix project load when intermediate output path isn't known #10198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether me or @DustinCampbell broke this, but hit this assert during debugging today. What was happening was:
ProjectKey
callsFilePathNormalizer.GetNormalizedDirectoryName
, passes innull
, and gets back/
ProjectKey
then callsFilePathNormalizer.NormalizeDirectory
on that/
, which explodedThis fixes the first bullet point, by checking if Roslyn knows about the intermediate output path before continuing. Since this is only checking for project existence, we don't actually need to go further.
This fixes the third point by protecting against a single
/
being written for an input that is only a single/
This ignores the second point because it doesn't really matter, though it is slightly wasteful to get a normalized directory name, and then normalize it.