Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove IProjectSnapshot.GetTagHelpersSynchronously() #9878

Closed
davidwengier opened this issue Jan 30, 2024 · 0 comments · Fixed by #11205
Closed

Fix/remove IProjectSnapshot.GetTagHelpersSynchronously() #9878

davidwengier opened this issue Jan 30, 2024 · 0 comments · Fixed by #11205
Assignees
@DustinCampbell
Labels
tech-debt
Milestone
Backlog

Comments

@davidwengier
Copy link
Contributor

#9871 introduced an extension method on IProjectSnapshot to allow getting tag helpers in non-async code, which only works in the legacy project system/editor, and takes advantage of the fact that that implementation doesn't do any async work. If we can refactor the things that use that extension method, we might be able to remove it entirely, which would be nice.

          Would you mind creating an issue to clean this up? I'm about to work on `VisualStudioDocumentTracker` as part of the MEF clean up, and I'd be happy to get rid of this at the same time.

Originally posted by @DustinCampbell in #9871 (comment)
@ghost ghost added the untriaged label Jan 30, 2024
@phil-allen-msft phil-allen-msft added this to the Backlog milestone Jan 30, 2024
@ghost ghost removed the untriaged label Jan 30, 2024
@DustinCampbell DustinCampbell self-assigned this Jan 30, 2024
@davidwengier davidwengier mentioned this issue Feb 1, 2024
Merged
davidwengier added a commit that referenced this issue Feb 1, 2024
@davidwengier
Fix false assert from legacy editor (#9889)
ae120b9 
There are 2 project snapshot types that are allowed to be non-async.

Will be cleaned up properly in
#9878 (hopefully)
@DustinCampbell DustinCampbell mentioned this issue Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DustinCampbell DustinCampbell

Labels
tech-debt
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Remove GetTagHelpersSynchronously extension method DustinCampbell/razor
3 participants
@DustinCampbell @davidwengier @phil-allen-msft