Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Microsoft.Net.Compilers.Toolset #9329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Microsoft.Net.Compilers.Toolset #9329

wants to merge 1 commit into from

Commits on Nov 13, 2023

  1. Remove Microsoft.Net.Compilers.Toolset 

    We've had a reference to this package for a long time even though it is only meant to be used to pick up hotfixes to the compiler before they make their way into an SDK update. We're not using it for that purpose; in general, moving to a new version of the SDK is the supported way of picking up a newer version of the compiler. And since we're not controlling the SDK version (we just use whatever is on the machine) we can't even guarantee that the package is in fact giving us a newer version.

Here we remove the package entirely. This also exposes that there was some sort of issue running the PublicAPI analyzer on our VB projects when using the Microsoft.Net.Compilers.Toolset package, and the PublicAPI.Shipped.txt files have been updated with the correct contents.
    @tmeschter
    tmeschter committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e97df98 View commit details
    Browse the repository at this point in the history