Cleanup ClientGenerator & Orleans.csproj bootstrap #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix-clientgenerator-cleanup
branch
from
6a805ad to
a624ee4
Compare
| <CodeGenArgs Include="/in:$(IntermediateOutputPath)$(TargetName)$(TargetExt)"/> | ||
| <CodeGenArgs Include="/cwd:$(ProjectDir)"/> | ||
| <CodeGenArgs Include="@(ReferencePath->'/r:%(Identity)')"/> | ||
| <CodeGenArgs Include="@(Compile->'/src:%(Identity)')"/> |
There was a problem hiding this comment.
This lets us perform all writes to the args file in one go, rather than bit-by-bit
ReubenBond
force-pushed
the
fix-clientgenerator-cleanup
branch
from
6fe6dd0 to
6f7cc2d
Compare
ReubenBond
force-pushed
the
fix-clientgenerator-cleanup
branch
from
6f7cc2d to
6b63ba1
Compare
sergeybykov
added a commit
that referenced
this pull request
Nov 2, 2015
Cleanup ClientGenerator & Orleans.csproj bootstrap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix cleans up the ClientGenerator project somewhat (as a part of the post-#528 work) and also implements a quick fix to Orleans.csproj's bootstrap process whereby the command line was too long and characters would randomly be dropped.
The bootstrap process does not need to pass a list of source files to the code generator since it no longer compiles assemblies itself.