Add dispose rule and handle it in solution (production part) #9983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
changed the title
src/Build.OM.UnitTests/Construction/ProjectRootElement_Tests.cs
Outdated
Show resolved
Hide resolved
src/Build/Logging/BinaryLogger/Postprocessing/StreamExtensions.cs
Outdated
Show resolved
Hide resolved
YuliiaKovalova
force-pushed
the
dev/ykovalova/enable_disposable_rule_check
branch
from
fd0332a
to
aa28c4f
Compare
YuliiaKovalova
force-pushed
the
dev/ykovalova/enable_disposable_rule_check
branch
from
aa28c4f
to
6b56301
Compare
YuliiaKovalova
changed the title
ladipro
reviewed
Apr 11, 2024
src/Build.OM.UnitTests/Microsoft.Build.Engine.OM.UnitTests.csproj
Outdated
Show resolved
Hide resolved
…github.com/YuliiaKovalova/msbuild into dev/ykovalova/enable_disposable_rule_check
YuliiaKovalova
force-pushed
the
dev/ykovalova/enable_disposable_rule_check
branch
from
8783283
to
6ef1733
Compare
ladipro
reviewed
Apr 12, 2024
src/Build/Logging/BinaryLogger/Postprocessing/StreamExtensions.cs
Outdated
Show resolved
Hide resolved
src/MSBuild.UnitTests/Microsoft.Build.CommandLine.UnitTests.csproj
Outdated
Show resolved
Hide resolved
ladipro
requested changes
Apr 15, 2024
YuliiaKovalova
force-pushed
the
dev/ykovalova/enable_disposable_rule_check
branch
from
96b0b7c
to
c8fee7e
Compare
ladipro
reviewed
Apr 17, 2024
ladipro
approved these changes
Apr 18, 2024
rainersigwald
approved these changes
Apr 18, 2024
src/Build.OM.UnitTests/Microsoft.Build.Engine.OM.UnitTests.csproj
Outdated
Show resolved
Hide resolved
rainersigwald
approved these changes
Apr 19, 2024
rainersigwald
pushed a commit
that referenced
this pull request
Apr 30, 2024
… available in the ClickOnce's bootstrapper packages folder (#10093) #9983 introduced a regression in ClickOnce's bootstrapper packages builder code by disposing an XmlReader object while it's still in use. Fix the bootstrapper builder code that validates against a schema file to use the XmlReaderSettings instead of the deprecated XmlValidatingReader class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The absence of this rule cause a memory leak during execution.
Changes Made
Enable CA2000 rule for production code and temporary make exception for test projects.