Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove result indicator from test summary #9929

Merged
merged 8 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
]9;4;3;\ project test succeeded (0.2s)
[?25l
[?25h
Test summary: total: 10, failed: 1, succeeded: 7, skipped: 2, duration: 1.0s
Build succeeded in 5.0s
Test run failed. Total: 10 Failed: 1 Passed: 7 Skipped: 2, Duration: 1.0s
]9;4;0;\
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
 project test succeeded (0.2s)
[?25l
[?25h
Test summary: total: 10, failed: 1, succeeded: 7, skipped: 2, duration: 1.0s
Build succeeded in 5.0s
Test run failed. Total: 10 Failed: 1 Passed: 7 Skipped: 2, Duration: 1.0s
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
]9;4;3;\ project test succeeded (0.2s)
[?25l
[?25h
Test summary: total: 10, failed: 1, succeeded: 7, skipped: 2, duration: 1.0s
Build succeeded in 5.0s
Test run failed. Total: 10 Failed: 1 Passed: 7 Skipped: 2, Duration: 1.0s
]9;4;0;\
91 changes: 49 additions & 42 deletions src/MSBuild/Resources/Strings.resx
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema

<!--
Microsoft ResX Schema
Version 2.0

The primary goals of this format is to allow a simple XML format
that is mostly human readable. The generation and parsing of the
various data types are done through the TypeConverter classes
The primary goals of this format is to allow a simple XML format
that is mostly human readable. The generation and parsing of the
various data types are done through the TypeConverter classes
associated with the data types.

Example:

... ado.net/XML headers & schema ...
<resheader name="resmimetype">text/microsoft-resx</resheader>
<resheader name="version">2.0</resheader>
Expand All @@ -26,36 +26,36 @@
<value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
<comment>This is a comment</comment>
</data>

There are any number of "resheader" rows that contain simple
There are any number of "resheader" rows that contain simple
name/value pairs.

Each data row contains a name, and value. The row also contains a
type or mimetype. Type corresponds to a .NET class that support
text/value conversion through the TypeConverter architecture.
Classes that don't support this are serialized and stored with the
Each data row contains a name, and value. The row also contains a
type or mimetype. Type corresponds to a .NET class that support
text/value conversion through the TypeConverter architecture.
Classes that don't support this are serialized and stored with the
mimetype set.

The mimetype is used for serialized objects, and tells the
ResXResourceReader how to depersist the object. This is currently not
The mimetype is used for serialized objects, and tells the
ResXResourceReader how to depersist the object. This is currently not
extensible. For a given mimetype the value must be set accordingly:

Note - application/x-microsoft.net.object.binary.base64 is the format
that the ResXResourceWriter will generate, however the reader can
Note - application/x-microsoft.net.object.binary.base64 is the format
that the ResXResourceWriter will generate, however the reader can
read any of the formats listed below.

mimetype: application/x-microsoft.net.object.binary.base64
value : The object must be serialized with
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
: and then encoded with base64 encoding.

mimetype: application/x-microsoft.net.object.soap.base64
value : The object must be serialized with
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Soap.SoapFormatter
: and then encoded with base64 encoding.

mimetype: application/x-microsoft.net.object.bytearray.base64
value : The object must be serialized into a byte array
value : The object must be serialized into a byte array
: using a System.ComponentModel.TypeConverter
: and then encoded with base64 encoding.
-->
Expand Down Expand Up @@ -1105,15 +1105,15 @@
LOCALIZATION: The prefix "MSBUILD : error MSBxxxx:" should not be localized.
</comment>
</data>
<data name="MissingFeatureAvailabilityError" UESanitized="true" Visibility="Public">
nohwnd marked this conversation as resolved.
Show resolved Hide resolved
<data name="MissingFeatureAvailabilityError" xml:space="preserve">
<value>MSBUILD : error MSB1067: Must provide a feature name for the featureavailability switch.</value>
<comment>
{StrBegin="MSBUILD : error MSB1067: "}UE: This happens if the user does something like "msbuild.exe -featureavailability". The user must pass in an actual feature name
following the switch, as in "msbuild.exe -featureavailability:blah".
LOCALIZATION: The prefix "MSBUILD : error MSBxxxx:" should not be localized.
</comment>
</data>
<data name="MissingGetItemError" UESanitized="true" Visibility="Public">
<data name="MissingGetItemError" xml:space="preserve">
<value>MSBUILD : error MSB1014: Must provide an item name for the getItem switch.</value>
<comment>
{StrBegin="MSBUILD : error MSB1014: "}UE: This happens if the user does something like "msbuild.exe -getItem". The user must pass in an actual item name
Expand Down Expand Up @@ -1641,17 +1641,24 @@
{4}: duration in seconds with 1 decimal point
</comment>
</data>
<data name="TestSummary" xml:space="preserve">
<value>Test run {0}. Total: {1} Failed: {2} Passed: {3} Skipped: {4}, Duration: {5}s</value>
<comment>{0} string, localized result e.g. Failed surrounded by ANSI colors.
{1-5} whole number</comment>
<data name="TestSummary_BannerAndTotal" xml:space="preserve">
<value>Test summary: total: {0}</value>
<comment>{0} whole number</comment>
</data>
<!-- **** TerminalLogger strings end **** -->
nohwnd marked this conversation as resolved.
Show resolved Hide resolved
<!--
The command line message bucket is: MSB1001 - MSB1999

Next error code should be MSB1069.

Don't forget to update this comment after using the new code.
-->
</root>
<data name="TestSummary_Duration" xml:space="preserve">
<value>duration: {0}s</value>
<comment>{0} whole number</comment>
</data>
<data name="TestSummary_Failed" xml:space="preserve">
<value>failed: {0}</value>
<comment>{0} whole number</comment>
</data>
<data name="TestSummary_Skipped" xml:space="preserve">
<value>skipped: {0}</value>
<comment>{0} whole number</comment>
</data>
<data name="TestSummary_Succeeded" xml:space="preserve">
<value>succeeded: {0}</value>
<comment>{0} whole number</comment>
</data>
nohwnd marked this conversation as resolved.
Show resolved Hide resolved
</root>
29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading