Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzers prototype proposal #9735

Merged
merged 44 commits into from
Apr 15, 2024
Merged

Analyzers prototype proposal #9735

merged 44 commits into from
Apr 15, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Feb 13, 2024

Context

Initial prototype of Analyzers/BuildCop project.
It's currently hidden behind a feature-flag in form of an explicit commandline argument

Design Doc

#9853

Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few comments.

src/Analyzers/Microsoft.Build.Analyzers.csproj Outdated Show resolved Hide resolved
src/Analyzers/API/PerformanceWeightClass.cs Outdated Show resolved Hide resolved
src/Analyzers/API/InvocationConcurrency.cs Outdated Show resolved Hide resolved
src/Analyzers/OM/ParsedItemsContext.cs Outdated Show resolved Hide resolved
@JanKrivanek JanKrivanek marked this pull request as ready for review February 20, 2024 15:01
@JanKrivanek JanKrivanek requested a review from a team as a code owner February 20, 2024 15:01
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at everything yet.

src/UnitTests.Shared/RunnerUtilities.cs Outdated Show resolved Hide resolved
src/Build/BuildCop/API/BuildAnalyzer.cs Outdated Show resolved Hide resolved
eng/BootStrapMSBuild.targets Outdated Show resolved Hide resolved
eng/cibuild_bootstrapped_msbuild.ps1 Outdated Show resolved Hide resolved
src/Analyzers.UnitTests/BootstrapRunner.cs Outdated Show resolved Hide resolved
src/Build/BuildCop/Analyzers/SharedOutputPathAnalyzer.cs Outdated Show resolved Hide resolved
src/Build/BuildCop/Analyzers/SharedOutputPathAnalyzer.cs Outdated Show resolved Hide resolved
src/Build/BuildCop/API/BuildAnalyzerResult.cs Outdated Show resolved Hide resolved
src/Analyzers.UnitTests/EndToEndTests.cs Outdated Show resolved Hide resolved
Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more inline comments. Looking forward to having this in main!

src/Framework/BuildCheck/BuildCheckEventArgs.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/Utilities/EnumerableExtensions.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/Utilities/EnumerableExtensions.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/Utilities/EnumerableExtensions.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/OM/ParsedItemsAnalysisData.cs Outdated Show resolved Hide resolved
src/MSBuild/CommandLineSwitches.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/API/ConfigurationContext.cs Outdated Show resolved Hide resolved
src/Framework/BuildCheck/IBuildCheckResult.cs Show resolved Hide resolved
src/Build/BuildCheck/Utilities/EnumerableExtensions.cs Outdated Show resolved Hide resolved
JanKrivanek and others added 3 commits April 5, 2024 17:59
Copy link
Contributor

@f-alizada f-alizada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting some questions/clarifications to get more details on the implementation and some small formatting suggestions.

src/Build/BuildCheck/API/BuildAnalyzer.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/API/BuildAnalyzer.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/API/BuildAnalyzerRule.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@f-alizada f-alizada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking one more time, every time have some clarifications,questions, sorry that I'm adding more comments in smaller chunks (some of them are regarding the testing basic coverage on some parts )

Co-authored-by: Farhad Alizada <104755925+f-alizada@users.noreply.github.com>
@YuliiaKovalova
Copy link
Member

Looks good to me!
I feel like it's time to merge it and address any issues in dedicated areas ;)

Copy link
Contributor

@f-alizada f-alizada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Thank you for addressing the comments:)

@JanKrivanek JanKrivanek merged commit f744eb5 into main Apr 15, 2024
9 checks passed
@JanKrivanek JanKrivanek deleted the exp/build-analyzers branch April 15, 2024 18:57
@YuliiaKovalova
Copy link
Member

YuliiaKovalova commented Apr 15, 2024 via email

@JanKrivanek JanKrivanek restored the exp/build-analyzers branch April 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants