Fix bug: Exec task trims leading whitespace in ConsoleToMsBuild #9722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surayya-MS
requested review from
rainersigwald,
rokonec,
YuliiaKovalova and
f-alizada
AR-May
reviewed
Feb 8, 2024
AR-May
approved these changes
Feb 8, 2024
f-alizada
approved these changes
Feb 9, 2024
rokonec
approved these changes
Feb 9, 2024
|
The change wave check should be documented in https://github.com/dotnet/msbuild/blob/main/documentation/wiki/ChangeWaves.md#1710. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9668
Context
See the issue description with example
Changes Made
Here the string is trimmed of all whitespace characters:
msbuild/src/Tasks/Exec.cs
Lines 411 to 413 in 195e7f5
I changed it to trim only the end, so that the leading whitespace characters are preserved in the output
Testing
Added a unit test and tried out the example in the issue manually
Notes