Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve msbuild logger for testing workloads #9706

Merged
merged 21 commits into from
Feb 19, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Feb 2, 2024

Part of microsoft/vstest#4843
Needs microsoft/vstest#4877 to work, but does not break without it.

Context

Terminal logger is reporting build, but when tests run via MSBuild there is very little feedback about what is going on.

logger

image

image

image

image

Changes Made

Adds colored test results where targets are normally.
Writes summary for tests after the test run.
Writes result for every test projects, no matter if it fails or succeeds.

Testing

yup.

Notes

In comments.

@baronfel
Copy link
Member

baronfel commented Feb 2, 2024

@rainersigwald aren't we working on removing the project prefix for each error report or something?

src/MSBuild/TerminalLogger/NodesFrame.cs Show resolved Hide resolved
src/MSBuild/TerminalLogger/TerminalLogger.cs Outdated Show resolved Hide resolved
src/MSBuild/TerminalLogger/TerminalLogger.cs Show resolved Hide resolved
src/Framework/Logging/AnsiCodes.cs Outdated Show resolved Hide resolved
src/MSBuild/TerminalLogger/TerminalLogger.cs Show resolved Hide resolved
@nohwnd nohwnd marked this pull request as ready for review February 8, 2024 15:41
@nohwnd
Copy link
Member Author

nohwnd commented Feb 8, 2024

@baronfel @rainersigwald @rokonec I am close to happy. Would love to know if I need to change something significantly.

src/MSBuild.UnitTests/NodeStatus_SizeChange_Tests.cs Outdated Show resolved Hide resolved
src/MSBuild/TerminalLogger/NodeStatus.cs Show resolved Hide resolved
src/MSBuild/TerminalLogger/NodeStatus.cs Show resolved Hide resolved
src/MSBuild/TerminalLogger/TerminalLogger.cs Outdated Show resolved Hide resolved
src/MSBuild/TerminalLogger/TerminalLogger.cs Show resolved Hide resolved
src/MSBuild/TerminalLogger/TerminalLogger.cs Show resolved Hide resolved
src/MSBuild/TerminalLogger/TestSummary.cs Outdated Show resolved Hide resolved
@rokonec rokonec merged commit 93c2acc into main Feb 19, 2024
8 checks passed
@rokonec rokonec deleted the exp/terminal-logger-for-vstest branch February 19, 2024 13:57
@nohwnd
Copy link
Member Author

nohwnd commented Feb 21, 2024

Available in dotnet/installer since 9.0.100-preview.2.24121.2 if anyone wants to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants