-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate RAR SearchPaths added because they're "next to a reference" #9700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
ladipro
reviewed
Feb 6, 2024
ladipro
approved these changes
Feb 6, 2024
rokonec
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider changing value tuple (string, string)
to readonly record struct
for maintanability purposes
rokonec
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9408
Context
When building this project from a Developer Command Prompt:
That produces this RAR snippet for Framework:
Changes Made
When calculating resolvers to resolve a reference we currently adding
DirectoryResolver
s for each directories of the reference's dependees:msbuild/src/Tasks/AssemblyDependency/ReferenceTable.cs
Lines 1282 to 1286 in 07fd5d5
Added
ParentAssembly
property to theResolver
to save that info to log it later for searchpath.Added new type of log message for this specific case:
Now same example produces:
Testing
Unit test for new log message and manual test
Notes