Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LangVersion to _GenerateCompileDependencyCache #9656

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add LangVersion to _GenerateCompileDependencyCache #9656

merged 1 commit into from
Jan 23, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 17, 2024 •
edited
Loading

Fixes dotnet/roslyn#71678

Context

Building with dotnet build -p:langversion=X then with dotnet build -p:langversion=Y considers the build up to date.

Changes Made

Include LangVersion as CoreCompileCache

Testing

Notes

@rainersigwald rainersigwald merged commit d51ae52 into dotnet:main Jan 23, 2024
8 checks passed
@Youssef1313 Youssef1313 deleted the patch-2 branch January 23, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@Forgind Forgind Forgind approved these changes

@AR-May AR-May AR-May approved these changes

Assignees
No one assigned
Labels
Area: Common Targets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use C# 11 feature in my source code, but the build command: dotnet build -p:langversion=10 built successfully.
4 participants
@Youssef1313 @rainersigwald @Forgind @AR-May