Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/roslyn, nuget/nuget.client #9642

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 15, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 848bf81b-14ec-482f-6736-08da008bd46a
  • Build: 20240204.1
  • Date Produced: February 4, 2024 9:29:13 PM UTC
  • Commit: d9272a3f01928b1c3614a942bdbbfeb0fb17a43b
  • Branch: refs/heads/main

From https://github.com/nuget/nuget.client

  • Subscription: 3fe128a9-5a85-4aba-f7ba-08da008becb5
  • Build: 6.10.0.18
  • Date Produced: January 30, 2024 8:27:11 PM UTC
  • Commit: f207cbb3530350f785d1b04014e15563cc9b5e03
  • Branch: dev

…113.2

Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.23629.3 -> To Version 4.10.0-1.24063.2
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner January 15, 2024 13:44
@JanKrivanek
Copy link
Member

One of the CSharpCompilationOptions ctor used by the ApiCompat task apparently removed in recent Roslyn update:

.dotnet\sdk\8.0.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidatePackageTask" task failed unexpectedly.
System.MissingMethodException: Method not found: 'Void Microsoft.CodeAnalysis.CSharp.CSharpCompilationOptions..ctor(Microsoft.CodeAnalysis.OutputKind, Boolean, System.String, System.String, System.String, System.Collections.Generic.IEnumerable`1<System.String>, Microsoft.CodeAnalysis.OptimizationLevel, Boolean, Boolean, System.String, System.String, System.Collections.Immutable.ImmutableArray`1<Byte>, System.Nullable`1<Boolean>, Microsoft.CodeAnalysis.Platform, Microsoft.CodeAnalysis.ReportDiagnostic, Int32, System.Collections.Generic.IEnumerable`1<System.Collections.Generic.KeyValuePair`2<System.String,Microsoft.CodeAnalysis.ReportDiagnostic>>, Boolean, Boolean, Microsoft.CodeAnalysis.XmlReferenceResolver, Microsoft.CodeAnalysis.SourceReferenceResolver, Microsoft.CodeAnalysis.MetadataReferenceResolver, Microsoft.CodeAnalysis.AssemblyIdentityComparer, Microsoft.CodeAnalysis.StrongNameProvider, Boolean, Microsoft.CodeAnalysis.MetadataImportOptions, Microsoft.CodeAnalysis.NullableContextOptions)'.
   at Microsoft.DotNet.ApiSymbolExtensions.AssemblySymbolLoader..ctor(Boolean resolveAssemblyReferences, Boolean includeInternalSymbols)
   at Microsoft.DotNet.ApiSymbolExtensions.AssemblySymbolLoaderFactory.Create(Boolean shouldResolveReferences)
   at Microsoft.DotNet.ApiCompatibility.Runner.ApiCompatRunner.CreateAssemblySymbols(IReadOnlyList`1 metadataInformation, ApiCompatRunnerOptions options, Boolean& resolvedExternallyProvidedAssemblyReferences)
   at Microsoft.DotNet.ApiCompatibility.Runner.ApiCompatRunner.ExecuteWorkItems()
   at Microsoft.DotNet.ApiCompat.ValidatePackage.Run(Func`2 logFactory, Boolean generateSuppressionFile, Boolean preserveUnnecessarySuppressions, Boolean permitUnnecessarySuppressions, String[] suppressionFiles, String suppressionOutputFile, String noWarn, Boolean respectInternals, Boolean enableRuleAttributesMustMatch, String[] excludeAttributesFiles, Boolean enableRuleCannotChangeParameterName, String packagePath, Boolean runApiCompat, Boolean enableStrictModeForCompatibleTfms, Boolean enableStrictModeForCompatibleFrameworksInPackage, Boolean enableStrictModeForBaselineValidation, String baselinePackagePath, String runtimeGraph, Dictionary`2 packageAssemblyReferences, Dictionary`2 baselinePackageAssemblyReferences)
   at Microsoft.DotNet.ApiCompat.Task.ValidatePackageTask.ExecuteCore()
   at Microsoft.NET.Build.Tasks.TaskBase.Execute()
   at Microsoft.DotNet.ApiCompat.Task.ValidatePackageTask.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

Waiting on infro from either of the 2 involved teams

@JanKrivanek
Copy link
Member

dotnet/sdk#32691

…119.13

Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.23629.3 -> To Version 4.10.0-1.24069.13
…6.10.0.9

NuGet.Build.Tasks
 From Version 6.9.0-preview.1.70 -> To Version 6.10.0-preview.1.9
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/roslyn [main] Update dependencies from dotnet/roslyn, nuget/nuget.client Jan 22, 2024
…126.10

Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.23629.3 -> To Version 4.10.0-1.24076.10
…6.10.0.12

NuGet.Build.Tasks
 From Version 6.9.0-preview.1.70 -> To Version 6.10.0-preview.1.12
…204.1

Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.23629.3 -> To Version 4.10.0-2.24104.1
…6.10.0.18

NuGet.Build.Tasks
 From Version 6.9.0-preview.1.70 -> To Version 6.10.0-preview.1.18
@JanKrivanek
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalPavlik
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalPavlik MichalPavlik merged commit e71eb7a into main Feb 8, 2024
8 checks passed
@MichalPavlik MichalPavlik deleted the darc-main-3dee7af6-19d8-4aa6-92ff-35b2fc1cd9aa branch February 8, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants