Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileAccessData Id and CorrelationId #9615

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Jan 9, 2024

Fixes #9616

Summary

This passes through 2 more fields from BuildXL to the project cache plugins.

MSBuildCache needs this information to do some copy tracing optimizations.

Customer Impact

Without this change, MSBuild Cache plug-ins will not be able to correlate copy source and destination events, which will prevent it from making some optimizations based on the knowledge for the specific ways files are accessed in the builds. This blocks the proposed optimizations in MSBuildCache, which is part of onboarding PowerToys and Terminal repos to use the MSBuild Cache.

Regression?

No

Testing

Manually tested that the new fields are being exposed to the plugins.

Risk

Low. This is an experimental feature and the change is additive.

@ghost
Copy link

ghost commented Jan 9, 2024

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@JanKrivanek JanKrivanek merged commit cb0858f into dotnet:vs17.9 Jan 18, 2024
8 checks passed
@dfederm dfederm deleted the file-access-data-id branch January 19, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants