Emit NETSDK1057 at most once in -tl #9610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#9602 by emitting NETSDK1057 as an immediate message at most once in the TerminalLogger. ```sh-session ❯ dotnet build MSBuild version 17.10.0-dev-24055-01+3500455af for .NET Restore complete (1.1s) You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy Lib1 succeeded (3.1s) → Lib1\bin\Debug\net9.0\Lib1.dll Lib2 succeeded (3.1s) → Lib2\bin\Debug\net9.0\Lib2.dll App succeeded (3.2s) → App\bin\Debug\net9.0\App.dll Build succeeded in 4.5s ```
rainersigwald
added
the
Area: Terminal Logger
rokonec
approved these changes
Jan 8, 2024
ladipro
approved these changes
Jan 8, 2024
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9602 by emitting NETSDK1057 as an immediate message at most once in the TerminalLogger.
It is slightly ugly to do this deduplication at the logger level, but it cleans up a customer annoyance so I think it's worth it.