Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to to indicate which process exactly hold the lock for the file for task Generate*Manifest #9488

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

JaynieBai
Copy link
Member

Fixes #9465

Context

Unable to write manifest ‘obj\Debug\bc.exe.manifest’. The process cannot access the file ‘C:\Source\bc\bc\obj\Debug\bc.exe.manifest’ because it is being used by another process.

With limited error message, can't tell which process exactly hold the lock for the file.

Changes Made

use original the Copy task's "name the process that holds the lock" approach for the task GenerateManifestBase

Testing

Notes

@AR-May
Copy link
Member

AR-May commented Dec 6, 2023

Please retarget this PR to vs17.9 branch, since this isn't a new feature.

@JaynieBai JaynieBai changed the base branch from main to vs17.9 December 11, 2023 03:03
@JaynieBai
Copy link
Member Author

Please retarget this PR to vs17.9 branch, since this isn't a new feature.

done

Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks!

src/Tasks/GenerateManifestBase.cs Show resolved Hide resolved
@JanKrivanek JanKrivanek changed the base branch from vs17.9 to main January 3, 2024 14:05
@JanKrivanek JanKrivanek merged commit f1be624 into main Jan 10, 2024
8 checks passed
@JanKrivanek JanKrivanek deleted the jennybai/issue9465 branch January 10, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File in use by another application during build
4 participants