Change Version switch output to finish with a newline #9485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that's conceivable. And for someone who has written code like that and hits this change, the defect would be mysterious. |
|
I think I should change the |
|
That sounds fine to me. |
|
Should this be in a change wave and should it be change wave 17.10? |
|
Yes and yes, please. |
rainersigwald
approved these changes
Dec 6, 2023
f-alizada
reviewed
Dec 7, 2023
f-alizada
reviewed
Dec 11, 2023
f-alizada
reviewed
Dec 12, 2023
rainersigwald
force-pushed
the
VersionMessage
branch
from
930db94 to
2a8e760
Compare
rainersigwald
approved these changes
Dec 12, 2023
f-alizada
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9482
Context
The -version switch doesn't terminate its output with a newline which some shells don't like.
Changes Made
ShowVersion().Testing
Tested on Windows 10 and macOS 14.
Tested by running the full unit test suite and by manually running the
-versionswitch under cmd (Windows), pwsh (Windows and macOS), and zsh (macOS).