Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete checks for retired change waves #9480

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Conversation

ladipro
Copy link
Member

@ladipro ladipro commented Nov 30, 2023

Context

We still have checks for a change wave that's already out of rotation.

Changes Made

[MSBuild]::AreFeaturesEnabled('17.0') is now unconditionally true, let's remove the checks from Microsoft.Common.CurrentVersion.targets.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should consider making a debug-only check in this property function to warn if there's an instance of a stale check like this.

@ladipro
Copy link
Member Author

ladipro commented Dec 1, 2023

I wonder if we should consider making a debug-only check in this property function to warn if there's an instance of a stale check like this.

I had the same thought after creating the PR. Technically the assert is validating user input which is generally discouraged but since the feature is used pretty much only internally I think it makes sense to add it. Done.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the assert is validating user input which is generally discouraged but since the feature is used pretty much only internally I think it makes sense to add it.

I agree--and I think making it debug-only is a good mitigation in case someone else is using it.

@AR-May AR-May merged commit 125647b into dotnet:main Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants