Fixed /restore and /graph conjunction error on exit code #9461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maridematte
changed the title
maridematte
changed the title
ladipro
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
nit: I think it would be slightly better if the success = assignments were done right after the respective results are calculated. The current code effectively repeats the condition graphResult != null && !saveProjectResult in two places in an non-obvious way and it would be easy to have them diverge and introduce a similar bug in the future. Especially given what a monster of a method this is.
|
I think we should target vs17.9 branch for this PR, since this is a bug? |
rainersigwald
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9443
Context
When the
/graphand/restoreare used within the same command, the build exit code will always be 0. This is because of the variable used to define success of the restore action overrides the success of the graph build.Changes Made
Added an extra condition when defining the success of the build to account for this case.
Testing
Made sure existing tests passed and added a unit test for this case, an some manual testing.