Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ui language override helper method for input language "en" #9392

Merged

Conversation

f-alizada
Copy link
Contributor

Fixes #9254

Context

DOTNET_CLI_UI_LANGUAGE enviroment variable was not respected when TwoLetterISOLanguageName of CultureInfo was equal to en.

Changes Made

Removed the additional check for described in the context case

Testing

Case covered by unit test of the method additionally to testing in debug mode.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One nit that . . . I don't think we have written down anywhere, which isn't great.

src/Utilities.UnitTests/EncodingUtilities_Tests.cs Outdated Show resolved Hide resolved
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@f-alizada f-alizada merged commit 50086fe into dotnet:main Nov 6, 2023
8 checks passed
@f-alizada f-alizada deleted the dev/f-alizada/overriden-languagen-envvar branch June 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DOTNET_CLI_UI_LANGUAGE ignored for English
4 participants