Right justify target and duration in terminallogger #9053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
force-pushed
the
right-justify
branch
from
1004bc8
to
9f42479
Compare
rainersigwald
force-pushed
the
right-justify
branch
3 times, most recently
from
a5bde06
to
2faecf2
Compare
rainersigwald
commented
Aug 1, 2023
rainersigwald
force-pushed
the
right-justify
branch
from
74b12fe
to
493d134
Compare
rainersigwald
force-pushed
the
right-justify
branch
from
26fb5cd
to
d9f1a29
Compare
baronfel
approved these changes
Nov 9, 2023
maridematte
approved these changes
Nov 9, 2023
rainersigwald
force-pushed
the
right-justify
branch
from
d9f1a29
to
b6ec555
Compare
Instead of the rendered string, with its invisible control characters.
I wanted control over equality, and we don't need the auto-generated stuff.
Move cursor right (it stops at end of line), then back to justify the output. This makes the localization less flexible since the formatting + justification is handled in code, but makes it a lot easier to understand. In the future reordering in translations would need to be handled fairly carefully. Avoid a bunch of overwrite problems by simplifiying the should-we-do-a-fancy-overwrite decision to "is just time tick" or "just overwrite it all".
rainersigwald
force-pushed
the
right-justify
branch
from
b6ec555
to
8f8dd68
Compare
YuliiaKovalova
approved these changes
Dec 1, 2023
|
Looks good ! |
rokonec
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right-justify target and duration. To do this, I changed the localization mechanism for in-progress targets to be a bit less flexible at the translation level (the order is now fixed in code), but that allows determining a bunch of per-message length characteristics, unlocking right-justification and context-aware truncation.