Create problematic test path on current tmp path #8122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: I suggest to rename this test. Something like WorksCorrectlyWithCurlyBraces :) |
MichalPavlik
approved these changes
Nov 3, 2022
Forgind
approved these changes
Nov 3, 2022
|
@rainersigwald Are we ok with renaming tests? We will lose history of runs for that tests in AzDO. Might not be as bad. |
rokonec
added
the
merge-when-branch-open
I'd prefer to have a good name for now + the future; I rarely look at history for tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Test CacheTest2 was failing on local test runs
build.cmd -testIt was caused by creating folder at
C:\Users\}\...which is allowed only for admin elevated processes.Changes Made
Problematic path created as subfolder of current path.
Only test was changed
Testing
Local run.