Add InternalsVisibleTo to common types schema #6778
Conversation
There was a problem hiding this comment.
LGTM. I was suspicious of the friend language, but it's used in the IVT docs.
| <xs:element name="InternalsVisibleTo" substitutionGroup="msb:Item"> | ||
| <xs:annotation> | ||
| <xs:documentation> | ||
| <!-- _locID_text="InternalsVisibleTo" _locComment="" -->Specifies that types that are ordinarily visible only within the assembly are visible to the specified assemblies. |
There was a problem hiding this comment.
I thought the exact same thing when I copied that text from the docs. It should likely be "types and members" to be even more correct. I'll give the wording a massage with the goal of just making it clearer here despite what the API docs have right now.
| <xs:attribute name="Include" type="xs:string"> | ||
| <xs:annotation> | ||
| <xs:documentation> | ||
| <!-- _locID_text="InternalsVisibleTo_Include" _locComment="" -->The name of the friend assembly to make internal types visible to, e.g. Microsoft.AspNetCore. |
There was a problem hiding this comment.
| <!-- _locID_text="InternalsVisibleTo_Include" _locComment="" -->The name of the friend assembly to make internal types visible to, e.g. Microsoft.AspNetCore. | |
| <!-- _locID_text="InternalsVisibleTo_Include" _locComment="" -->The name of the friend assembly that gains visibility to internals of the other assembly. |
?
There was a problem hiding this comment.
The text is basically lifted exactly from the ref docs for the attribute. I think we should keep them the same so if we want to change it here we should change it there too.
InternalsVisibleToAttribute class description:
Specifies that types that are ordinarily visible only within the current assembly are visible to a specified assembly.
AssemblyName property description:
Gets the name of the friend assembly to which all types and type members that are marked with the internal keyword are to be made visible.
There was a problem hiding this comment.
Personally, I would prefer they both change. It had been very unclear, and it is in our style docs not to use things like e.g. because they aren't technically English.
If you want to leave it this way, though, I'm not blocking its insertion.
- Uses "internal types and members" - Standardizes on "friend assembly" given that's the official term in docs already, inc. for InternalTypesVisibleToAttribute - Removed "e.g." instance
Forgind
added
the
merge-when-branch-open
|
Can we get this into .NET 6? |
|
Should be able to. RPS has been flaky lately, but I'm rerunning it. I can prioritize this among the not-yet-merged PRs. |
Fixes #6777
Since .NET 5, the
<InternalsVisibleTo Include="MyProject.Assmebly" />item type has been supported to generate theSystem.Runtime.CompilerServices.InternalsVisibleTofor the output assembly. The definition for this item type should be in the common types schema file so that editors (like Visual Studio) provide statement completion and a QuickInfo tooltip for it.