Don't import Microsoft.WinFX.targets for sdk style projects #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmihai
reviewed
Mar 27, 2020
cdmihai
approved these changes
Mar 27, 2020
rainersigwald
approved these changes
Mar 27, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Nirmal4G
reviewed
Mar 31, 2020
|
Verified that this works locally 👍 |
rainersigwald
requested changes
Apr 3, 2020
…ng them" This reverts commit 07a6146.
rainersigwald
approved these changes
Apr 7, 2020
sfoslund
pushed a commit
to sfoslund/msbuild
that referenced
this pull request
May 15, 2020
) * Conditional import on microsoft.winfx.targets * Escape hatch for logging ALL task inputs rather than truncating them * Short circuiting the condition to prevent a file check if the property is false. * Changed name to be more explicit * Revert "Escape hatch for logging ALL task inputs rather than truncating them" This reverts commit 07a6146.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 to fix #4948
Part 2 (sets the ImportWinFXTargets property to false): dotnet/sdk#10998
This conditionally imports winfx.targets for all non-sdk style builds. Pairs with another PR for the sdk
that ensures the condition will fall through.