Enable WinMDExp task on .NET Core MSBuild #5078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This task will fail at runtime unless the .NET Framework SDK is installed, since winmdexp.exe is only present in that SDK. However, nothing about the task itself is incompatible with .NET Core. See also microsoft/microsoft-ui-xaml#1891. Contributes to dotnet/sdk#3042.
cdmihai
suggested changes
Mar 3, 2020
Path.Combine() no longer throws if given invalid path characters, as per source file linked below. https://github.com/dotnet/runtime/blob/a69888e80ff0a08ce75970165fb409ea852ff5bc/src/libraries/System.Private.CoreLib/src/System/IO/Path.cs#L323-L328
cdmihai
approved these changes
Mar 17, 2020
|
I'm going to close this PR following the announcement that direct referencing of winmd files is deprecated and will be removed from the runtime in .NET 5 RTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task will fail at runtime unless the .NET Framework SDK is installed, since winmdexp.exe is only present in that SDK. However, nothing about the task itself is incompatible with .NET Core. Furthermore, the error message that occurs if this happens is already very explanatory as to what needs to be done, so no changes are required there.
See also microsoft/microsoft-ui-xaml#1891.
Contributes to dotnet/sdk#3042.